1143788 - SHB: The Emergency Callback mode exit prompt dialog doesn't fit on the screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Anshul]

The buttons at the bottom of the screen are clipped. Please see the attached snapshot.

Comment 1

[Anshul]

Attachment: CDMA Emergency Callback Mode

Comment 2

[Gregor Wagner [:gwagner]]

How do you get to this screen?

Comment 3

[Anshul]

(In reply to Gregor Wagner [:gwagner] from comment #2)
> How do you get to this screen?

You need to dial emergency call on a network that supports emergency callback mode such as Verizon or simulate this in a test environment.

Comment 4

[Gregor Wagner [:gwagner]]

(In reply to Anshul from comment #3)
> (In reply to Gregor Wagner [:gwagner] from comment #2)
> > How do you get to this screen?
> 
> You need to dial emergency call on a network that supports emergency
> callback mode such as Verizon or simulate this in a test environment.

does QA have a test that triggers this dialog?

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

We have at least 11 manual tests in regards to getting into ECM:
https://moztrap.mozilla.org/manage/case/9453/
Having said that, I think our Taipei testers run these tests.

I don't see any gip tests, gij tests, nor unit tests for this area.  Maybe I might have missed something...

Comment 6

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

I'll take a look at this. I'm not clear yet on how to get to this screen though. The MozTrap scripts seem to indicate I actually have to call emergency services and hang up on them - I don't think they are going to like that and at least in some regions will send someone to my address to investigate in case there is a problem I was trying to communicate (my son did this once when he was 2 - first we knew was police knocking on the door)

Meantime I'll look to see if I can mock some stuff in an integration test

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

There might be some procedure in regards to contacting the services to let them know you're doing a test.  You may want to see if there's something like that in your area.

From John Hammink : 
"You have to find out who handles 911 calls locally, and you can reach out to them, stating that you have a phone system on which you want to test emergency services.  

Took a bit of digging but in our case, it's these people:  http://www.mountainview.gov/safety/911.asp. 

When I call 911 for testing, i always do the following things:

1. Dial 911
2. Announce that it is not an emergency and that you are testing 911 services from a new phone system.
3. Have the 911 operator verify the phone number you are calling from to make sure they are seeing the correct CID info, and in our case, cell tower.  

The operator was very helpful and shared the information she saw on her screen."

Following his email, I found that there is a website for at least for the US : http://www.911.gov/State911Sites.html

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Also you may want to look at mocking w/ unit tests?

Comment 9

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

There is some basic unit testing for the emergency callback manager at: apps/system/test/unit/emergency_callback_icon_test.js, and a mock at apps/system/test/unit/mock_emergency_callback_manager.js

For the purposes of testing this, it looks like I just need to dispatch a "emergencycbmodechange" event with { active: true|false, timeoutMs: Nms } from window.navigator.mozMobileConnections[0].

Comment 10

[Michael Vines [:m1] [:evilmachines]]

It might also be helpful to note that the soft home button is enabled (which visible in the screenshot so forgive me if I'm stating the obvious).  Other Gaia popup dialogs do seem to respect this area though.

One way to turn this on:
$ adb shell setprop ro.moz.has_home_button 0

Comment 11

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #10)
> It might also be helpful to note that the soft home button is enabled (which
> visible in the screenshot so forgive me if I'm stating the obvious).  Other
> Gaia popup dialogs do seem to respect this area though.

Yeah I was able to reproduce this with the soft home button enabled. Working on a patch + test.

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:shb-emergency-callback-dialog-bug-1143788 > mozilla-b2g:master

Comment 13

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

To manually test this patch, I'm enabling SHB in Settings > Developer. Then, in WebIDE I'm typing in the console: 

var evt = new CustomEvent('emergencycbmodechange')
evt.active = true;
evt.timeoutMs = 1000;
window.navigator.mozMobileConnections[0].dispatchEvent(evt);

That gives you the notification, which you can click to get the dialog in question.

Comment 14

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

Comment on attachment 8579705 [details] [review]
[gaia] sfoster:shb-emergency-callback-dialog-bug-1143788 > mozilla-b2g:master

Still trying to get a gaia-try run for this, with all the tree closures i've not had any luck yet. But maybe you can look it over in the meantime?

Comment 15

[Kevin Grandon :kgrandon]

Comment on attachment 8579705 [details] [review]
[gaia] sfoster:shb-emergency-callback-dialog-bug-1143788 > mozilla-b2g:master

Looks good to me. Thanks for adding the test.

Comment 16

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#QNnckDGPRfWWILWnA6-Bpg

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 17

[Kevin Grandon :kgrandon]

(In reply to Autolander from comment #16)
> http://docs.taskcluster.net/tools/task-graph-inspector/#QNnckDGPRfWWILWnA6-
> Bpg
> 
> The pull request failed to pass integration tests. It could not be landed,
> please try again.

This seems like a taskcluster problem. I'm currently chatting with folks in #taskcluster about this.

Comment 18

[Kevin Grandon :kgrandon]

I've updated autolander after some problems with the Gij test suite. Going to use your bug as a guinea pig if you don't mind.

Comment 19

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/00dcb9fb68752e436b81381637dc7f3ae0f119b1

Comment 20

[Hermes Cheng (inactive after July 27, 2015)]

Could you please uplift to v2.2? Thanks. ;)

Comment 21

[Michael Vines [:m1] [:evilmachines]]

Comment on attachment 8579705 [details] [review]
[gaia] sfoster:shb-emergency-callback-dialog-bug-1143788 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 22

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

Comment on attachment 8579705 [details] [review]
[gaia] sfoster:shb-emergency-callback-dialog-bug-1143788 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Software Home Button 
[User impact] if declined: The Ok/Cancel buttons on the Emergency Callback Dialog are obscured and difficult to read/click when using the software home button
[Testing completed]: New integration test, tested on device
[Risk to taking this patch] (and alternatives if risky): Low risk, CSS-only patch for just this dialog
[String changes made]: None

Comment 23

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/27d2f94f0281bf5519a74ed2a0978a105869d2b0

Comment 24

[Ryan VanderMeulen [:RyanVM]]

Reverted for JS integration test failures.
v2.2: https://github.com/mozilla-b2g/gaia/commit/a9c115c2bfec193d0e9e55f760c92aabe9005b02

https://treeherder.mozilla.org/logviewer.html#?job_id=79846&repo=mozilla-b2g37_v2_2

Comment 25

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:v2-2-shb-emergency-callback-dialog-bug-1143788 > mozilla-b2g:v2.2

Comment 26

[Sam Foster [:sfoster] (PTO until 2026-01-05) (he/him)]

Comment on attachment 8581870 [details] [review]
[gaia] sfoster:v2-2-shb-emergency-callback-dialog-bug-1143788 > mozilla-b2g:v2.2

My bad, sometime since we branched, the system test boilerplate changed and I was missing the ftu and lockscreen settings. 

Waiting for some Gaia-Try results before landing

Comment 27

[Kevin Grandon :kgrandon]

Comment on attachment 8581870 [details] [review]
[gaia] sfoster:v2-2-shb-emergency-callback-dialog-bug-1143788 > mozilla-b2g:v2.2

Thanks for the quick fix.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/dc2468102eddbc5701095955ac4e9bdfa9ea0f90

Comment 29

[Hermes Cheng (inactive after July 27, 2015)]

Norry, could you help verify this bug?

Comment 30

[Hermes Cheng (inactive after July 27, 2015)]

It seems we cannot use flame to verify this bug which is CDMA only.
Anshul, could you please help verify it has been fixed?

Comment 31

[Anshul]

The issue is resolved.