1143853 - Dial attempts with invalid SIM have no error message

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Michael Schwartz [:m4]]

STR:
# Insert a SIM (ICC) card
# Settings->Cellular and Data->Network Operator->Network Type select GSM or CDMA whichever is not present on the card

Expected: "Card is not compatible with preference selection" or some error of the sort
Observed: Silent fail

Comment 1

[Michael Schwartz [:m4]]

Sorry I hit submit too quickly.

The above scenario causes the following to hit https://github.com/mozilla-b2g/gaia/blob/v2.2/apps/communications/dialer/js/telephony_helper.js#L121

which in turn fails at https://github.com/mozilla-b2g/gaia/blob/v2.2/apps/communications/dialer/js/dialer.js#L464 which basically does nothing.  The error function should actually display a message.

Comment 2

[Michael Schwartz [:m4]]

This might be especially egregious since it look like it would fail emergency call requests as well.  I recommend you simply remove all these checks and let the lower layers do this for you.

Comment 3

[howie [:howie]]

Triage: No error message should be a rather minor issue, but emergency call should be work. Moving to RIL for checking why emergency call fails.

Comment 4

[bhavana bajaj [:bajaj]]

Ni'inh :hsinyi, as we spoke offline about this and she's going to look into this and comment in here, if this is more of a dialer or a RIL issue.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Michael Schwartz [:m4] from comment #0)
> STR:
> # Insert a SIM (ICC) card
> # Settings->Cellular and Data->Network Operator->Network Type select GSM or
> CDMA whichever is not present on the card
> 
> Expected: "Card is not compatible with preference selection" or some error
> of the sort
> Observed: Silent fail

I did some hack in mozril - setting netowrkType CDMA for a Gsm SIM card. But the error message "Preferred network type: Network type could not be set" was displayed as expected.

(In reply to Michael Schwartz [:m4] from comment #2)
> This might be especially egregious since it look like it would fail
> emergency call requests as well.  I recommend you simply remove all these
> checks and let the lower layers do this for you.

In my test, I could still dial out an emergency call even I intentionally set to an invalid network type. But I agree that removing the checks from the dialer makes more sense.


(In reply to howie [:howie] from comment #3)
> Triage: No error message should be a rather minor issue, but emergency call
> should be work. Moving to RIL for checking why emergency call fails.

No, this bug wasn't talking about emergency call failing. Instead, per comment 2, this bug was mainly mentioning that Dialer should not block emergency calls by any chance. So, change the component back to Gaia::Dialer.

Comment 6

[Michael Schwartz [:m4]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #5)=
> I did some hack in mozril - setting netowrkType CDMA for a Gsm SIM card. But
> the error message "Preferred network type: Network type could not be set"
> was displayed as expected.

You're right that will work as expected.  This is for the unlikely case that the network type is CDMA when the card is GSM or vice versa - say if the card is swapped.

> In my test, I could still dial out an emergency call even I intentionally
> set to an invalid network type. But I agree that removing the checks from
> the dialer makes more sense.

Is the card state being reported as 'unknown' in that case?  Just curious about how that would work...

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Michael Schwartz [:m4] from comment #6)
> (In reply to Hsin-Yi Tsai [:hsinyi] from comment #5)=
> > I did some hack in mozril - setting netowrkType CDMA for a Gsm SIM card. But
> > the error message "Preferred network type: Network type could not be set"
> > was displayed as expected.
> 
> You're right that will work as expected.  This is for the unlikely case that
> the network type is CDMA when the card is GSM or vice versa - say if the
> card is swapped.
> 
> > In my test, I could still dial out an emergency call even I intentionally
> > set to an invalid network type. But I agree that removing the checks from
> > the dialer makes more sense.
> 
> Is the card state being reported as 'unknown' in that case?  Just curious
> about how that would work...

The card state is "ready" that isn't affected by the network type selected. Actuallt I was also curious how you ended up with hitting that check because the condition looks unlikely to happen to me.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Triage: Clearing the nom while we get more information on how the unknown state has been set. Please renominate it again if somebody finds out how.

Comment 9

[Inder]

ni: m4 to address comment 7.

Comment 10

[Inder]

Discussed with m4 and it's not a blocker anymore.

Comment 11

[BMO Automation]

Firefox OS is not being worked on