Closed
Bug 1143864
Opened 11 years ago
Closed 11 years ago
Replace |FILTER bug_link| in loops by direct calls to bug/link.html.tmpl to improve performance
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
4.61 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
From bug 912531 comment 11:
- |FILTER bug_link| is definitely slow, because TT is slow to do recursions. Way too slow to be used in loops. I replaced it by a direct call to bug/link.html.tmpl, which is much faster. This is also why I objected to fix bug 115796. It would be a *huge* performance regression.
Attachment #8578260 -
Flags: review?(dkl)
|
||
Comment 1•11 years ago
|
||
Depending on which lands first, either bug 1105568's patch or this one will need updating :-)
|
|
||
Comment 2•11 years ago
|
||
(So we use the template directly for flagmail too)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8578260 [details] [diff] [review]
patch, v1
Review of attachment 8578260 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8578260 -
Flags: review?(dkl) → review+
|
|
||
Updated•11 years ago
|
Flags: approval?
Flags: approval5.0?
|
|
||
Updated•11 years ago
|
Flags: approval?
Flags: approval5.0?
Flags: approval5.0+
Flags: approval+
|
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to Ed Morley [:edmorley] from comment #2)
> (So we use the template directly for flagmail too)
I did this fix on checkin.
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
d1c18ff..cb8ec96 master -> master
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
038774e..467bef6 5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•