1143916 - [RTL][Lockscreen] Battery Charge Time Remaining display does not match parentheses

Status: RESOLVED DUPLICATE of bug 1144205

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect, P1)

Description

[Oliver Nelson [:oliverthor]]

Attachment: rtl_lockscreen_parentheses_mismatched.png

Description:
When the user plugs in their device and views the lockscreen, the charge time remaining is now displayed. In an RTL language, the parentheses are misplaced on the text.

PreReq:
* RTL Language (Arabic)
Repro Steps:
1) Update a Flame to 20150316010202
2) Plug in device
3) Lock phone
4) Observe lockscreen: charge time remaining.


Actual:
Parentheses are placed at the front of text (don't close eachother) in RTL.
Ex: (Charged (1h 13 mins remaining 1%

Expected:
Parentheses follow formatting on lockscreen and close eachother
Ex: (1h 13 mins) Charged 1% 	//unsure of accurate formatting


Environmental Variables:
--------------------------------------------------
Device: Flame 3.0
Build ID: 20150316010202
Gaia: 4868c56c0a3b7a1e51d55b24457e44a7709ea1ae
Gecko: 436686833af0
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0
==========================================
Feature was not available for 2.2 on flame devices BUT as of today (battery charge time bug 1116368) has landed. Should be in tomorrow's nightly.

Device: Flame 2.2
BuildID: 20150316002502
Gaia: a6b2d3f8478ec250beb49950fecbb8a16465ff6f
Gecko: 18619f8f6c5c
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
--------------------------------------------------


Repro frequency: 5/5
See attached: 
screenshot

Comment 1

[Dylan Oliver [:doliver]]

triage: blocking -- high visibility and the information is unreadable in this format.

Comment 2

[howie [:howie]]

ni Greg to take a look

Comment 3

[howie [:howie]]

Hi Zibi, you did the feature in bug 1115921 , so can you help on this blocker?

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ugh, sure. Stas, do I just need the <bdi> around it? I don't understand why it doesn't work without it :(

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Olivier, what locale have you been using? This is not a Mirrored English (RTL pseudolocale), this is not any of the RTL locales.

The reason it is broken is because you are displaying en-US strings in RTL mode, which will, always, break parenthesis.

Comment 6

[howie [:howie]]

Hi Olivier, can you provide answer to comment 5?

Comment 7

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

I confirm it works fine on my Flame when I use Mirrored English.

Comment 8

[Joshua Mitchell (Inactive)]

I can field this question - 

In step 0 he states:
 PreReq:
* RTL Language (Arabic)

I can confirm that this is still occurring in todays build

Environmental Variables:
Device: Flame Master (KK - Nightly - Full Flashed - 319 mem)
Build ID: 20150324010202
Gaia: efebbafd12fc42ddcd378948b683a51106517660
Gecko: 840cfd5bc971
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (Master)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 9

[Joshua Mitchell (Inactive)]

Attachment: 2015-03-24-09-52-37.png

Here is an example from today's build

Comment 10

[Staś Małolepszy :stas]

Hey Joshua -- which locale is this?  Also see comment 5.

Comment 11

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

This is likely arabic (see comment 8) falling back to english because the string is not translated yet.

Comment 12

[Staś Małolepszy :stas]

Is this a dupe of bug 1144205 then?

Comment 13

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

Either this or just mark as invalid because we don't have the right localized strings yet.

Comment 14

[Staś Małolepszy :stas]

OK, let's close this as dupe.  Thanks for the report, Joshua!  We'll take care of the root cause in bug 1144205.