1143939 - Add single item delete to about:passwords context menu

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Deletion should be part of the context menu for a password item.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

By design, I have placed the "Delete" function inside the actual login. Users have to click into an "edit mode" before they get the option to "delete".

Comment 2

[Chenxia Liu [:liuche]]

Talked with :antlam, and we'll actually have Delete as a context menu item, and eliminate the details page altogether. Clicking delete will display a confirmation dialog.

Comment 3

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: bz://1143939/liuche

/r/6175 - Bug 1143939 - Add single-item delete to about:passwords context menu. r=ally

Pull down this commit:

hg pull review -r 93e935db293cc4261039c485706304e7726c14e2

Comment 4

[Allison Naaktgeboren :ally]

Comment on attachment 8584085 [details]
MozReview Request: bz://1143939/liuche

https://reviewboard.mozilla.org/r/6173/#review5185

Ship It!

::: mobile/android/chrome/content/aboutPasswords.js
(Diff revision 1)
> +                  // Corresponds to "confirm" button.

thank you for adding a comment for the magic number

Comment 5

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/a47e2631d62b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a47e2631d62b

Comment 7

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Nexus 4 (Android 4.4)
Build: Firefox for Android 39.0a1 (2015-03-30)
Tapping on an item from about:passwords list will invoke the context menu. "Delete" is the last option  present and choosing it will display a confirmation dialog."Delete this login?" with two buttons: "Cancel" and "OK".

Comment 9

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: Bug 1143939 - Add single-item delete to about:passwords context menu. r=ally