1143984 - B2G NetworkManager: 'active' should only set for default connections, e.g. wifi or default data

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Jessica Jong [:jessica] (inactive)]

Currently, NetworkManager's |active| may be set to a secondary data connection, e.g. mms. However, we think |active| should only be set for default connections, e.g. wifi or default data.

Comment 1

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 2

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8579270 [details] [diff] [review]
patch, v1.

I think this is ready. Edgar, may I have your review? Thanks.

Comment 3

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8579270 [details] [diff] [review]
patch, v1.

Cancelling review since we need to fix dns default interface issue, see Bug 992772.

Comment 4

[Jessica Jong [:jessica] (inactive)]

Attachment: WIP.

Fix dns default interface issue, not tested yet.

Comment 5

[Jessica Jong [:jessica] (inactive)]

Hmm, I'm still finding a way to test SDK_VERSION 18, since base image v123 (JB) seems not to work with master. It makes me wonder if we need that ugly fix for SDK_VERSION 18, since it doesn't work current master and it is no longer supported on Flame:

"Note: Firefox OS images v180 and above are based on Android KK (Kitkat, 4.4); JB (Jellybean, 4.1–4.3) builds have now been discontinued and are no longer supported, so don't use anything older than v180."

https://developer.mozilla.org/en-US/Firefox_OS/Phone_guide/Flame/Updating_your_Flame

Comment 6

[Jessica Jong [:jessica] (inactive)]

We'll wait for bug 992772 to be landed first.

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[Tracking Requested - why for this release]:

Comment 8

[Edgar Chen [:edgar]]

(In reply to Jessica Jong [:jjong] [:jessica] from comment #5)
> Hmm, I'm still finding a way to test SDK_VERSION 18, since base image v123
> (JB) seems not to work with master. It makes me wonder if we need that ugly
> fix for SDK_VERSION 18, since it doesn't work current master and it is no
> longer supported on Flame:
> 
> "Note: Firefox OS images v180 and above are based on Android KK (Kitkat,
> 4.4); JB (Jellybean, 4.1–4.3) builds have now been discontinued and are no
> longer supported, so don't use anything older than v180."
> 
> https://developer.mozilla.org/en-US/Firefox_OS/Phone_guide/Flame/
> Updating_your_Flame

I just found OPEN_C is still using jellybean. Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1114935#c150.
Looks like we still need to take jellybean into consideration. :(

Comment 9

[Jessica Jong [:jessica] (inactive)]

(In reply to Edgar Chen [:edgar][:echen] (OOO 3/21~4/6) from comment #8)
> (In reply to Jessica Jong [:jjong] [:jessica] from comment #5)
> > Hmm, I'm still finding a way to test SDK_VERSION 18, since base image v123
> > (JB) seems not to work with master. It makes me wonder if we need that ugly
> > fix for SDK_VERSION 18, since it doesn't work current master and it is no
> > longer supported on Flame:
> > 
> > "Note: Firefox OS images v180 and above are based on Android KK (Kitkat,
> > 4.4); JB (Jellybean, 4.1–4.3) builds have now been discontinued and are no
> > longer supported, so don't use anything older than v180."
> > 
> > https://developer.mozilla.org/en-US/Firefox_OS/Phone_guide/Flame/
> > Updating_your_Flame
> 
> I just found OPEN_C is still using jellybean. Please see
> https://bugzilla.mozilla.org/show_bug.cgi?id=1114935#c150.
> Looks like we still need to take jellybean into consideration. :(

Alright, I will let Henry know. :)

Comment 10

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 11

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8605703 [details] [diff] [review]
patch, v1.

Edgar, may I have you review on this, now that bug 992772 has landed? Thanks!

Comment 12

[Edgar Chen [:edgar]]

Comment on attachment 8605703 [details] [diff] [review]
patch, v1.

Review of attachment 8605703 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you.

Comment 13

[Jessica Jong [:jessica] (inactive)]

try looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f6f564d2713

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/3c346649c98f

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3c346649c98f