1144020 - Repair Folder of BerkeleyStore Mbox should start from messageKey=1 and use increment=1

Status: VERIFIED FIXED

(MailNews Core :: Backend, enhancement)

Description

[WADA:World Anti-bad-Duping Agency]

+++ This bug was initially created as a clone of Bug #854798 +++

Repair Folder of BerkeleyStore Mbox should start from messageKey=1 and use increment=1.
Increment=1 is currently used by :
  - message filter move to BerkeleyStore Mbox, when multiple message move to an Mbox at once 
  - when message is placed near 4GB, incremented by 1 to avoid messageKey overflow/wrap around.

Comment 1

[:aceman]

It seems most of this is going to be solved in bug 1183490. So changing dependence. We'll see if anything needs to be done afterwards.

Comment 2

[:aceman]

Now that bug 1183490 is done, can you recheck if the numbering is as expected?

Comment 3

[WADA:World Anti-bad-Duping Agency]

Checked with trunk nightly.
> Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:47.0) Gecko/20100101 Thunderbird/47.0a1
> Application Build ID 	20160228030411

1. Compact : messageKey is not changed
2. Copy/Move mails : messageKey starts from 1, and is incremented by 1
3. Repair Folder   : messageKey starts from 1, and is incremented by 1

All works as designed, as expected.

Comment 4

[WADA:World Anti-bad-Duping Agency]

Additional check
4. Delete -> Compact -> Copy/Move -> Repair Folder :
   messageKey is not changed by Compact
   messageKey is incremented by 1 from Highest messageKey upon Copy/Move.
     "Re-use of messageKey by Copy/Move" doesn't occur. Bug 1202105 is resolved.
   messageKey starts from 1 and is incremented by 1 upon repair Folder.
     "Re-use of messageKey of deleted mail" can occur by Repait Folder.
     If composer refers to the messageKey of deleted mail(==messageKey re-used after Repair Folder),
     problem of bug 1201782 can occur after Delete/Compact/Copy/Move + Repair Folder.