1144196 - "Undo close tab" toast does not appear after performing specific scnearios

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Robert (rrayborn, he/him)]

I've seen a few comments that suggest that users are not seeing the Toast in some circumstances.  The most common case is that users are requesting a way to "Undo close tab" because they think a method doesn't exist.  This could mean one of two things:
  1) [Minor] They actually mean that they want a way to "Undo close tab" after the Toast fades away.  This would be a good minor feature request, but doesn't concern me much.
  2) [Moderate] They aren't seeing the Toast at all.  This would be of more concern since they'd be missing important interactions.
Unfortunately I don't think that I have any more visibility on my end to figure out which is the case.

I'm not seeing this tied to a specific version, brand, OS version, etc.

Examples:
  https://input.mozilla.org/en-US/dashboard/response/4782118
  https://input.mozilla.org/en-US/dashboard/response/5173133
  https://input.mozilla.org/en-US/dashboard/response/4835015
  https://input.mozilla.org/en-US/dashboard/response/4490470
  https://input.mozilla.org/en-US/dashboard/response/4766243

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Rob from comment #0)
>   1) [Minor] They actually mean that they want a way to "Undo close tab"
> after the Toast fades away.  This would be a good minor feature request, but
> doesn't concern me much.

If you go to the home page (i.e. about:home, from a new tab, or clicking the url bar), you can scroll to the "Recent Tabs" panel to find a list of recently closed tabs.

Granted, this isn't very discoverable.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Michael Comella (:mcomella) from comment #1)

> Granted, this isn't very discoverable.

It's as discoverable as anything else in the app. It's a first class panel in the UI the displays every time you make a new tab or enter a new URL.

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

One of the major areas we don't offer an undo close tab is this workflow

* Open a link from an external app in Firefox
* Press the back button

* Tab is closed without any way to undo

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Kevin Brosnan [:kbrosnan] from comment #3)
> One of the major areas we don't offer an undo close tab is this workflow
> 
> * Open a link from an external app in Firefox
> * Press the back button
> 
> * Tab is closed without any way to undo

It does show up in the Recent Tabs panel for me.

Comment 5

[Robert (rrayborn, he/him)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> (In reply to Michael Comella (:mcomella) from comment #1)
> 
> > Granted, this isn't very discoverable.
> 
> It's as discoverable as anything else in the app. It's a first class panel
> in the UI the displays every time you make a new tab or enter a new URL.

I think that the issue is that the user expects this behavior to be in the Tab menu, not in the panels (perhaps since they're viewing it as an action on a tab not as historical event?).


Taking a step back, my intention of filing this bug was more to report that we *might* have an issue with the toast appearing (since we've seen other issues with the toast on the Xoom).  There's a good chance that nothing is wrong, but I wanted people with greater knowledge here to be the ones to make that call.

Comment 6

[u421692]

Scenario 1:
1. Long tap on a link and open in new tab
2. Tap on switch button from toast notification
3. Tap on back button

Scenario 2:
1. Close a tab from tabs tray(only on new tablet UI)

Actual result:
On both scenarios the Undo toast notification is not displayed.
Implementing "Undo close tab" when closing other ways then by tapping the "x" close button would be nice, so the users have all the scenarios covered

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Mihai Pop from comment #6)
> Scenario 1:
> 1. Long tap on a link and open in new tab
> 2. Tap on switch button from toast notification
> 3. Tap on back button

I think this is low priority.

> Scenario 2:
> 1. Close a tab from tabs tray(only on new tablet UI)

But this is higher priority: filed bug 1179864.

Comment 8

[Chenxia Liu [:liuche]]

If I close two tabs in quick succession, the "undo close tab" toast for the second tab shows up for an unclickable amount of time, or not at all. 

I disagree that this is a low priority, this seems like a clear regression from previous behavior.

(I find that about every third time I try to swipe-close a tab I accidentally close two because of the positioning of the "x", but that's a different issue, but it does make this bug much more frustrating.)

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Scenario 1 is a low priority. Minus

Comment 10

[:Margaret Leibovic]

(In reply to Chenxia Liu [:liuche] from comment #8)
> If I close two tabs in quick succession, the "undo close tab" toast for the
> second tab shows up for an unclickable amount of time, or not at all. 
> 
> I disagree that this is a low priority, this seems like a clear regression
> from previous behavior.
> 
> (I find that about every third time I try to swipe-close a tab I
> accidentally close two because of the positioning of the "x", but that's a
> different issue, but it does make this bug much more frustrating.)

You should be able to use the recent tabs panel to undo closing tabs (that's where we display all the tab data we have from session store).

Would that address scenario 1?

Comment 11

[Sebastian Kaspari (:sebastian; :pocmo)]

I see three things here:

* Scenario 1: We decided that this has low priority: Should we file a follow-up or is the priority so low that we just don't care? (NI: Margaret)

* Scenario 2: That's fixed in bug 1179864.

* Scenario 3: "If I close two tabs in quick succession, the "undo close tab" toast for the second tab shows up for an unclickable amount of time, or not at all". I saw that too and it was quite annoying. This does not happen with the snackbar implementation (bug 1204760). So there's no real incentive to fix this.

Comment 12

[:Margaret Leibovic]

(In reply to Sebastian Kaspari (:sebastian) from comment #11)

> * Scenario 1: We decided that this has low priority: Should we file a
> follow-up or is the priority so low that we just don't care? (NI: Margaret)

Let's not worry about it. We can see if anyone complains.

Worst case, they should be able to access closed tabs from the recent tabs panel.