Closed Bug 1144231 Opened 7 years ago Closed 7 years ago

browser_polaris_prefs.js doesn't cleanup the preference at the end of the test

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file, 2 obsolete files)

in bug 1081343, browser_polaris_prefs.js was added.  While testing stuff locally, I ran into this test case as failing when run a second time, this is because the prefs are not reset at the end.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #8578767 - Flags: review?(tkolodziejski)
Comment on attachment 8578767 [details] [diff] [review]
cleanup preferences at the end of browser_polaris_prefs.js (1.0)

On line 45, just add:

registerCleanupFunction(function () {
  Services.prefs.clearUserPref(POLARIS_ENABLED);
});
Attachment #8578767 - Flags: review?(tkolodziejski) → review-
Oh no, not on that line. One sec.
Just add that to line 40 I guess.
Attached patch cleanup a single pref (1.1) (obsolete) — Splinter Review
doing what is similar to requested in previous review feedback.
Attachment #8578767 - Attachment is obsolete: true
Attachment #8578960 - Flags: review?(gavin.sharp)
Attached patch patchSplinter Review
I realized my suggestion wasn't quite right either so figured the easiest counter point was in the form of a patch. Feel free to just push this assuming it works for you.
Attachment #8578960 - Attachment is obsolete: true
Attachment #8578960 - Flags: review?(gavin.sharp)
Attachment #8578984 - Flags: feedback?(jmaher)
Comment on attachment 8578984 [details] [diff] [review]
patch

Review of attachment 8578984 [details] [diff] [review]:
-----------------------------------------------------------------

this works great, I will land it!
Attachment #8578984 - Flags: review+
Attachment #8578984 - Flags: feedback?(jmaher)
Attachment #8578984 - Flags: feedback+
https://hg.mozilla.org/mozilla-central/rev/7f565d761d0c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
You need to log in before you can comment on or make changes to this bug.