1144231 - browser_polaris_prefs.js doesn't cleanup the preference at the end of the test

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in bug 1081343, browser_polaris_prefs.js was added.  While testing stuff locally, I ran into this test case as failing when run a second time, this is because the prefs are not reset at the end.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: cleanup preferences at the end of browser_polaris_prefs.js (1.0)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8578767 [details] [diff] [review]
cleanup preferences at the end of browser_polaris_prefs.js (1.0)

On line 45, just add:

registerCleanupFunction(function () {
  Services.prefs.clearUserPref(POLARIS_ENABLED);
});

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Oh no, not on that line. One sec.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Just add that to line 40 I guess.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: cleanup a single pref (1.1)

doing what is similar to requested in previous review feedback.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I realized my suggestion wasn't quite right either so figured the easiest counter point was in the form of a patch. Feel free to just push this assuming it works for you.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8578984 [details] [diff] [review]
patch

Review of attachment 8578984 [details] [diff] [review]:
-----------------------------------------------------------------

this works great, I will land it!

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f565d761d0c

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7f565d761d0c