1144263 - Update remaining calles of newChannel to newChannel2 in media/webrtc

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1144263_update_webrtc.patch

Byron,

we are about to attach a LoadInfo object to every channel that holds information like who initiated the load (the loadingPrincipal) or what content type the channel is about to load. Please find a detailed description of all the arguments here:
http://mxr.mozilla.org/mozilla-central/source/netwerk/base/nsNetUtil.h#190

My current patch uses the systemPrincipal as the loadingPrincipal which is obviously not that great for webrtc - we can discuss in person and hopefully find a better solution.

Comment 2

[Byron Campen [:bwc]]

If you want to use something other than the systemPrincipal, you'll have to get it from PeerConnectionImpl (PeerConnectionMedia::GetPC()), and use that to get the window (GetWindow()).

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Attachment: bug_1144263_update_webrtc.patch

(In reply to Byron Campen [:bwc] from comment #2)
> If you want to use something other than the systemPrincipal, you'll have to
> get it from PeerConnectionImpl (PeerConnectionMedia::GetPC()), and use that
> to get the window (GetWindow()).

As discussed in person, this is exactly what we want :-)

Thanks for your help, but you still have to sign off on it!

Comment 4

[Byron Campen [:bwc]]

Comment on attachment 8578919 [details] [diff] [review]
bug_1144263_update_webrtc.patch

Review of attachment 8578919 [details] [diff] [review]:
-----------------------------------------------------------------

Hey, one less line of code. Cool.

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8b190d37b21

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b8b190d37b21