Closed Bug 1144307 Opened 7 years ago Closed 7 years ago

nsDisplayScrollLayer leaks on try w/ APZ

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: dvander, Assigned: mstange)

References

Details

Attachments

(1 file, 1 obsolete file)

When I do a try run w/ APZ enabled, I get some new memory leaks for nsDisplayScrollInfoLayer and friends. Might be related to bug 1141595.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5637ecd545aa
Assignee: nobody → mstange
I've tried to reproduce this using
> mach mochitest --setpref layers.async-pan-zoom.enabled=true --setpref layout.event-regions.enabled=true browser/base/content/test/chat
but I don't get any leaks on Mac with that. David, can you test whether that command reproduces the problem for you on Windows?
Nevermind, I think I know what's going on. We need to call the destructor manually of any display item that has been removed from the display list that's passed to ProcessDisplayItems.
Attached patch patch (obsolete) — Splinter Review
Attachment #8579082 - Flags: review?(tnikkel)
Attached patch patchSplinter Review
Oops. This one compiles.
Attachment #8579082 - Attachment is obsolete: true
Attachment #8579082 - Flags: review?(tnikkel)
Attachment #8579085 - Flags: review?(tnikkel)
Status: NEW → ASSIGNED
Attachment #8579085 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/mozilla-central/rev/e9fe53bf495c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Blocks: 1141595
You need to log in before you can comment on or make changes to this bug.