1144338 - [it] Moving existing strings between tables removes it from builds

Status: RESOLVED INVALID

(Firefox for iOS :: General, defect)

Description

[Jeff Beatty [:gueroJeff]]

Attachment: Screen Shot 2015-03-17 at 11.14.12 AM.png

When a string is moved from one string table to another (and thus one <file> element to another), Xcode seems to not pick up the change and display the string appropriately in the target locale. 

"Add to Bookmarks", an existing string, was moved to another <file>. After importing Italian strings and looking for the string in it's previous location, it appears to be missing in the UI (see screenshot).

We would expect to see the string remain in the appropriate location, despite it moving to a different <file>.

Comment 1

[Francesco Lodolo [:flod]]

(In reply to Jeff Beatty [:gueroJeff] from comment #0)
> "Add to Bookmarks", an existing string, was moved to another <file>. After
> importing Italian strings and looking for the string in it's previous
> location, it appears to be missing in the UI (see screenshot).

In case of Italian I did move them in the right place, so I'd expect the screen to be fully localized
http://viewvc.svn.mozilla.org/vc?view=revision&revision=139237

Just want to make sure before I try to clean up the files and move them in "Client/Localizable.strings".

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #1)
> Just want to make sure before I try to clean up the files and move them in
> "Client/Localizable.strings".

Some more context. My file had 72 strings against 58 of English, run a script to remove obsolete files (r139210), and then realized I was missing 4 strings (added in r139237), which are basically the strings that were moved from one file to the other.

If this doesn't create a fully localized build, I clearly don't want to repeat the procedure for other locales.

Comment 3

[Francesco Lodolo [:flod]]

Installed XCode 6.2, imported translation and exported, found a ton of new strings (I wonder if we can ignore tests...). See r139374 for details.

Then imported the strings, run the simulator, everything seems localized but the Boorkmarks button. Could it be a problem with that specific button? See also comment in other bug, I think you're actually looking at English in this screenshot.

Comment 4

[Francesco Lodolo [:flod]]

It seems indeed not localizable (from what I understand of Swift code, which is very little)
https://github.com/mozilla/firefox-ios/blob/46647ae016374c1a8a6a68ea0f818741a005191e/Client/Frontend/Browser/BrowserToolbar.swift#L58-L61

Please also add a note that it's a verb, not a noun, as in "Add to bookmark".