Enable jit code randomization on windows x64

RESOLVED FIXED in Firefox 41

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: evilpie, Unassigned)

Tracking

({sec-want})

unspecified
mozilla41
x86_64
Windows 8
sec-want
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

(Whiteboard: [adv-main41-])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Sad story, this was apparently disabled for a sunspider regression in bug 728623!
http://mxr.mozilla.org/mozilla-central/source/js/src/jit/ExecutableAllocatorWin.cpp#232
(Reporter)

Updated

3 years ago
Blocks: 558448
Linking the bugs to create a path from that code comment to here.
Depends on: 728623
In quick testing I don't see the regression anymore. Definitely not the 2x slowdown seen in bug 728623. I tried both the current sunspider 1.0.2 and the 0.9.1 as originally filed. I guess 3 years can do a lot to the code!

I'm going to put up a patch and let the experts tell me what to scrutinize more closely.
Created attachment 8604904 [details] [diff] [review]
Re-enable JIT code randomization on Win64

I just did a few local tests on the sunspider website. The overall score goes slightly down with this patch, but I think it's noise. In any case it's certainly not regressing.

What further testing should I do on this patch? Do you guys have local command line perf tests or things like that?
Attachment #8604904 - Flags: review?(jdemooij)
Comment on attachment 8604904 [details] [diff] [review]
Re-enable JIT code randomization on Win64

Review of attachment 8604904 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

The original sunspider regression is gone so we should just land this IMO.
Attachment #8604904 - Flags: review?(jdemooij) → review+
Ok, fair enough!

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d24046cb041
https://hg.mozilla.org/mozilla-central/rev/6d24046cb041
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Whiteboard: [adv-main41-]
You need to log in before you can comment on or make changes to this bug.