Closed
Bug 114438
Opened 23 years ago
Closed 23 years ago
Ensure nsSharableString doesn't overwrite shared buffers
Categories
(Core :: XPCOM, defect, P2)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla0.9.7
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(1 file)
|
9.91 KB,
patch
|
dbaron
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
There are two ways that nsSharableString might overwrite shared buffers:
1) SetLength() can cause overwriting since it doesn't check the buffer's refcount
2) using writing iterators can cause ovewriting. It's not clear how we should
solve this problem in the long term (see bug 114140), but a short-term solution
that works is to override GetWritableFragment. The long-term solution may
involve changing all the users.
I'll attach the patch that fixes these two issues, which I'd like to get in for
0.9.7. I previously attached a superset of this patch to bug 112548 (and asked
jag to review the subset that I'm attaching here).
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Comment 2•23 years ago
|
||
Comment on attachment 61104 [details] [diff] [review]
patch
Transferring r=jag from bug 112548, attachment 61050 [details] [diff] [review]
Attachment #61104 -
Flags: review+
|
|
Assignee | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.7
|
||
Comment 3•23 years ago
|
||
Comment on attachment 61104 [details] [diff] [review]
patch
sr=jst
Attachment #61104 -
Flags: superreview+
dbaron landed the fix on 12/10/2001 19:33
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•