114448 - IN CRL autoupdate prefs window, should remove the menu for update from url

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P1)

Description

[Rangan Sen]

This menu is not relevant unless we support any more options other than the 
'update from last fetched url'

Comment 1

[Rangan Sen]

->me

Comment 2

[Rangan Sen]

Attachment: patch

Removed the idea of advertised url altogether - untill we have support for the
same in NSS. So, urlType also goes away from prefs. Its always last fetch url.

Comment 3

[Rangan Sen]

Kai, Please review ...

Comment 4

[Kai Engert [:KaiE:]]

Patch looks good, but one question: Why do you store the preference, when there
is only one possible setting? Should we remove that code, too?

Comment 5

[Rangan Sen]

Do you mean the storing the url string? [The url type is not being stored 
any amore]Because the autoupdate scheduler 
[nsNSSComponent::getParamsForNextCrlToDownload ]checks for which crl to update 
next, and then tries to import the crl directly from the corresp stored url 
string. This operation is much less costly than looking up for the crl in the 
db, and and finding out the lastfetchurl String 

Comment 6

[Kai Engert [:KaiE:]]

Comment on attachment 61138 [details] [diff] [review]
patch

I thought you were storing a flag whether you do "last fetch" or "as
advertised".

r=kaie

Comment 7

[Joe Hewitt (gone)]

Comment on attachment 61138 [details] [diff] [review]
patch

sr=hewitt

Comment 8

[Rangan Sen]

Patch checked in ...

Comment 9

[John Unruh]

Verified.