1144500 - [SHB] Tapping SHB causes input to lose focus

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

This is very easy to do when switching keyboard contexts (ie. from characters to numbers) and causes the keyboard to go away. It's especially easy to do on devices like Aries, and is quite annoying.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

This is probably a polish bug, but if we have people dogfooding aries devices with 2.2, I guarantee we will want to fix this.

Comment 2

[Gregor Wagner [:gwagner]]

How should we fix this?

Comment 3

[Stephany Wilkes]

Flagging Omega for suggestions on keyboard. We definitely need to fix this.

Comment 4

[Gregor Wagner [:gwagner]]

Omega, any updates here?

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1144500-no-pointer-events-shb > mozilla-b2g:master

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8582098 [details] [review]
[gaia] mikehenrty:bug-1144500-no-pointer-events-shb > mozilla-b2g:master

Kevin, what do you think about doing something like this to prevent the keyboard from closing when accidentally tapping the SHB bar?

Right now this patch makes it so that taps on the SHB bar are recognized by the keyboard and map to the key above it. We'll also have to see what UX thinks about this.

Comment 7

[Omega Feng [:Omega] [:馮於懋]]

I don't have an Aries, but it seems a bug which should be fixed. @Rudy, do you have any thought on this?

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

FWIW, this bug also reproduces on Flame with SHB enabled, but the problem is not as pronounced.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

IMHO, the proposed solution in comment 6 looks good to me.
Thanks.

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8582098 [details] [review]
[gaia] mikehenrty:bug-1144500-no-pointer-events-shb > mozilla-b2g:master

Sounds good to me.

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8582098 [details] [review]
[gaia] mikehenrty:bug-1144500-no-pointer-events-shb > mozilla-b2g:master

Unfortunately, this simple approach won't work. Tap events will get forwarded to any app under the SHB, which includes things like the homescreen. So right now you could accidentally open an app by tapping on the SHB, which I think is unexpected and strange behavior.

Instead I will investigate using the touch forwarder, and only forward the taps when the underlying app is the keyboard.

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1144500-no-pointer-events-shb > mozilla-b2g:master

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1144500-no-pointer-events-shb > mozilla-b2g:master

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8583422 [details] [review]
[gaia] mikehenrty:bug-1144500-no-pointer-events-shb > mozilla-b2g:master

I found a simpler approach that I think works well. Etienne or Kevin, one of you wanna have a look?

Comment 15

[Kevin Grandon :kgrandon]

Comment on attachment 8583422 [details] [review]
[gaia] mikehenrty:bug-1144500-no-pointer-events-shb > mozilla-b2g:master

Etienne, could you take this? Otherwise maybe Alive could do it? I am slammed right now so I won't get to this in a timely manner. Thanks!

Comment 16

[Etienne Segonzac (:etienne)]

Comment on attachment 8583422 [details] [review]
[gaia] mikehenrty:bug-1144500-no-pointer-events-shb > mozilla-b2g:master

Perfect, just a small comment about a comment :)

Comment 17

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/7969b367a7da62877c3a24a26d3cb5fda89d766c

Comment 18

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8583422 [details] [review]
[gaia] mikehenrty:bug-1144500-no-pointer-events-shb > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Not a regression. SHB always stole focus.

[User impact] if declined:
Really poor UX on aries device, accidentally dismissing keyboard often.

[Testing completed]:
Manually tested, added a couple marionettes tests.

[Risk to taking this patch] (and alternatives if risky):
Risk is to SHB handindling clicks, very low risk. I can't think of another way to do this, and even if I did it would probably be higher risk.

[String changes made]: none.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/dc9cd80a6aa5f02100784196244b3dc5fd5e28ba

Comment 20

[Hermes Cheng (inactive after July 27, 2015)]

verified with below build.
*2.2
Build ID               20150416162504
Gaia Revision          d50b8a3919a7b4d8d289f150d3b9bed704ebafa9
Gaia Date              2015-04-16 21:46:57
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5ebf32030512
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150416.195720
Firmware Date          Thu Apr 16 19:57:29 EDT 2015
Bootloader             L1TC000118D0

*master
Build ID               20150416160206
Gaia Revision          3cd0a9facce26c2acc7be3755a17131a6358e33f
Gaia Date              2015-04-16 16:33:22
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/51e3cb11a258
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150416.191700
Firmware Date          Thu Apr 16 19:17:10 EDT 2015
Bootloader             L1TC000118D0