Closed
Bug 1144511
Opened 11 years ago
Closed 11 years ago
Serve reader mode content via the built-in web server
Categories
(Firefox for iOS :: Reader View, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | + | --- |
People
(Reporter: st3fan, Assigned: st3fan)
References
Details
Attachments
(1 file)
This solved a bunch of problems. See all the blocked bugs.
| Assignee | ||
Comment 1•11 years ago
|
||
This patch changes reader view to serve content via the built-in web server. This results in much better interaction with the `WKWebView` because we now display reader view content by calling `webView.loadRequest()` instead of `webView.loadHTML`.
This also solved the following two issues:
* 1144291 - Navigating to a reader mode page from the history stack results in blank page
* 1144510 - Reader view content is cached permenantly
This patch is also the beginning of cached and offline reader view content. Standard practice now is to store the readerized content into `~/Library/Caches/ReaderView/XX/YY/ZZZZZZZZ/content.json` - there is currently no way to expire this content, but that will likely be hooked up when we do reading list syncing.
There are a couple of outstanding bugs that need to followup this one because I did not want to combine too much in a single PR. Including:
* 1144404 - Reader Mode URLS (about:reader) should not be part of history
* 1145231 - Internal Reader View URLs should be hidden
Attachment #8580423 -
Flags: review?(bnicholson)
Comment 2•11 years ago
|
||
Comment on attachment 8580423 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/242
Some comments in the PR, but looks good with those fixed.
Attachment #8580423 -
Flags: review?(bnicholson) → review+
| Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
tracking-fennec: ? → +
You need to log in
before you can comment on or make changes to this bug.
Description
•