1144514 - [gonk-lmr1] Whitelist pread64

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Michael Vines [:m1] [:evilmachines]]

The bionic linker uses pread64() [1] instead of read() [2] in L MR 1.  security/sandbox/linux/SandboxFilter.cpp   needs to be updated to whitelist pread64() so the homescreen doesn't get killed.

[1] http://androidxref.com/5.1.0_r1/xref/bionic/linker/linker_phdr.cpp#145
[2] http://androidxref.com/5.0.0_r2/xref/bionic/linker/linker_phdr.cpp#145

Comment 1

[Mike Lee [:mlee]]

Hi Michael Wu & Shawn Ku,

Please help route this to the appropriate owner.

Thanks,
Mike

Comment 2

[Michael Wu [:mwu]]

Jed, want to take this?

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Patch

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5ac8a04b63e

Comment 5

[Michael Vines [:m1] [:evilmachines]]

(goto v2.2+, as we do really need this)

Comment 6

[Keven Kuo [:kkuo]]

Comment on attachment 8580203 [details] [diff] [review]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 7

[bhavana bajaj [:bajaj]]

waiting for m-c landing before approving on branch.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/5aaf90d7a1e3

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5aaf90d7a1e3

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c9aedbe001f7