1144515 - [gonk-lmr1] Adapt to ConsumerListener interface changes in gonknativewindow/libdisplay

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Michael Vines [:m1] [:evilmachines]]

BufferItem was introduced into ConsumerListener [1], which causes a ripple effect through widget/gonk/{gonknativewindow,libdisplay}

[1] http://androidxref.com/5.1.0_r1/diff/frameworks/native/include/gui/IConsumerListener.h?r2=%2Fframeworks%2Fnative%2Finclude%2Fgui%2FIConsumerListener.h%408dc55396fc9bc425b5e2c82e76a38080f2a655ff&r1=%2Fframeworks%2Fnative%2Finclude%2Fgui%2FIConsumerListener.h%40399184a4cd728ea1421fb0bc1722274a29e38f4a

Comment 1

[Mike Lee [:mlee]]

Hi Michael Wu & Shawn Ku,

Please help route this to the appropriate owner.

Thanks,
Mike

Comment 2

[Michael Vines [:m1] [:evilmachines]]

Attachment: 0004-Bug-1144515-ConsumerListener-interface-changes.patch

Little ugly (#ifdefs, a gnarly cast, 'BufferItem' name conflict). But OTOH, this patch does seem work well on L MR1 so maybe that's something.  Please steal, I'm a PTO for next two weeks.

Note that these are minimal changes for L MR1, that is the addition BufferItem to 'onFrameAvailable' is ignored as is the new 'onFrameReplaced' method.  Not sure if Gecko might like to use this new facility in the future, I honestly haven't thought about it that much :)

Comment 3

[Michael Vines [:m1] [:evilmachines]]

(goto v2.2+, as we do really need this)

Comment 4

[shawn ku [:sku]]

Comment on attachment 8581064 [details] [diff] [review]
0004-Bug-1144515-ConsumerListener-interface-changes.patch

Review of attachment 8581064 [details] [diff] [review]:
-----------------------------------------------------------------

mwu is the proper one to review this patch.

mwu, please help review this patch.

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

I applied this patch locally and it does work properly.

Comment 6

[Michael Wu [:mwu]]

Comment on attachment 8581064 [details] [diff] [review]
0004-Bug-1144515-ConsumerListener-interface-changes.patch

Review of attachment 8581064 [details] [diff] [review]:
-----------------------------------------------------------------

Touches nativewindow, so passing review to sotaro.

Comment 7

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8581064 [details] [diff] [review]
0004-Bug-1144515-ConsumerListener-interface-changes.patch

Review of attachment 8581064 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. If we need to use onFrameReplaced() in future b2g, we need additional change to GonkNativeWindow.

Comment 8

[Kai-Zhen Li [:seinlin][:kli]]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=34857d936909

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7bd2bc8251bf

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7bd2bc8251bf

Comment 11

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8581064 [details] [diff] [review]
0004-Bug-1144515-ConsumerListener-interface-changes.patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Gonkintegration
User impact if declined: b2g build on L will not work properly.
Testing completed: verify on master
Risk to taking this patch (and alternatives if risky): low, update api to Lmr1 accordingly
String or UUID changes made by this patch: none

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ee218cbd5dd1

Comment 13

[Hermes Cheng (inactive after July 27, 2015)]

Ryan, it seems be landed to b2g37_v2_2, so let's updated the status flag. Please correct it if I misunderstood.