1144561 - Create branch for platform_external_libnfc-nci

Status: RESOLVED DUPLICATE of bug 1136512

(Taskcluster :: General, defect)

Description

[Dimi Lee [ooo 16.04 - 21.04］]

According to comment 4 and comment 6 in bug 1136512, we need to update patch for libnfc-nci.
https://github.com/mozilla-b2g/platform_external_libnfc-nci

So we require a new branch for shinano.

Comment 1

[Dimi Lee [ooo 16.04 - 21.04］]

Hi Hal,
Could you help create a new branch shinano for 
https://github.com/mozilla-b2g/platform_external_libnfc-nci

Comment 2

[Hal Wine [:hwine] use NI!]

The b2g team handles all branching in mozilla-b2g repository. Moving to correct product & component

Comment 3

[Dimi Lee [ooo 16.04 - 21.04］]

Hi Hal,
Do you know if there is anyone could also help on this ? Thanks

Comment 4

[Hal Wine [:hwine] use NI!]

sorry, no. jlal suggested this location. Maybe :mwu ?

Comment 5

[Michael Wu [:mwu]]

Generate your branch and I'll copy it over.

Comment 6

[Dimi Lee [ooo 16.04 - 21.04］]

Hi Michael,
I would like to have a branch from
git://www.codeaurora.org/platform/external/libnfc-nci with refs/tags/android-4.4.4_r2

But should we consider about the branch naming in b2g repository ? Because I will update some patches after branch is created and those patches will for shinano only based on comment 6 in bug 1136512

Comment 7

[Michael Wu [:mwu]]

You will need to create a corresponding change in the manifest to switch to the new branch. Look at the naming conventions there, pick a name, create a PR to update the manifest, and request review from gerard-majax.

Comment 8

[Dimi Lee [ooo 16.04 - 21.04］]

Attachment: pull request to mozilla-b2g/b2g-manifest

Hi,
This pull request is to change libnfc-nci repository path to our b2g repository because I will need to update some patches for shinano

Comment 9

[:gerard-majax]

Looks good, what is the status on this tree, can we safely default to it right now without breaking builds ?

Comment 10

[Dimi Lee [ooo 16.04 - 21.04］]

(In reply to Alexandre LISSY :gerard-majax from comment #9)
> Looks good, what is the status on this tree, can we safely default to it
> right now without breaking builds ?

The branch is not yet created, but once it is created, we can default to it without breaking builds.

Comment 11

[:gerard-majax]

(In reply to Dimi Lee[:dimi][:dlee] from comment #10)
> (In reply to Alexandre LISSY :gerard-majax from comment #9)
> > Looks good, what is the status on this tree, can we safely default to it
> > right now without breaking builds ?
> 
> The branch is not yet created, but once it is created, we can default to it
> without breaking builds.

Do you mind creating it now, before that I review?

Comment 12

[Michael Wu [:mwu]]

(In reply to Alexandre LISSY :gerard-majax from comment #11)
> Do you mind creating it now, before that I review?

I don't think dimi has commit access to the repo. The details of the branch he wants is in comment 6.

Comment 13

[:gerard-majax]

Comment on attachment 8586538 [details] [review]
pull request to mozilla-b2g/b2g-manifest

This looks good to me. I'm waiting for your PR to push this branch :)

Comment 14

[Michael Wu [:mwu]]

The shinano branch, based on android-4.4.4_r2, is now up. https://github.com/mozilla-b2g/platform_external_libnfc-nci/tree/shinano

Comment 15

[Michael Wu [:mwu]]

Where's your PR for libnfc-nci?

Comment 16

[Dimi Lee [ooo 16.04 - 21.04］]

(In reply to Michael Wu [:mwu] from comment #15)
> Where's your PR for libnfc-nci?

I am going to do it in bug 1136512, do you think it would be better do it here ?

Comment 17

[Dimi Lee [ooo 16.04 - 21.04］]

There is discussion about whether we should maintain our own repository for libnfc-nci or not in 	bug 1136512, The fix would be handled in that bug when we have made decision.

Comment 18

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...