Closed Bug 1144569 Opened 10 years ago Closed 9 years ago

[Super Search] Return only a subset of columns for each result

Categories

(Socorro Graveyard :: Middleware, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: adrian, Assigned: adrian)

References

(Depends on 1 open bug)

Details

We currently return a lot of data for each result of a search, and most of that data won't be used by whoever is calling it (be it the webapp or a user through the public API). We could optimize our service by allowing to choose the set of fields to return for each result.
I think a small set of default fields (id, signature at least) makes sense, and adding others only when defined by the user.
Blocks: 1149187
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/a39acf41c5d23ea9db65ec619e4c1449ce7253b5 Fixes bug 1144569 - Configurable returned columns for Super Search middleware service. r=peterbe
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 1130542
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/cfe1e6eacd8fd7907a5e626928d659e33852ae0e Revert "Fixes bug 1144569 - Configurable returned columns for Super Search middleware service. r=peterbe" This reverts commit a39acf41c5d23ea9db65ec619e4c1449ce7253b5.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/416133d93f3b76a342691fe75cd86e38a6f85e29 Fixes bug 1144569 - Configurable returned columns for Super Search middleware service. r=peterbe
Status: REOPENED → RESOLVED
Closed: 10 years ago9 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 1162105
Depends on: 1163149
I added bug 1163149 about querying on a range/set of versions.
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/86c42363ce7026f4b093b9b245326d6f6fe32940 Fixes bug 1144569 - Configurable returned columns for Super Search middleware service. r=peterbe Conflicts: webapp-django/crashstats/crashstats/tests/test_views.py webapp-django/crashstats/crashstats/views.py webapp-django/crashstats/signature/tests/test_views.py webapp-django/crashstats/supersearch/models.py webapp-django/crashstats/supersearch/tests/common.py webapp-django/crashstats/supersearch/tests/test_views.py https://github.com/mozilla/socorro/commit/1fc9d14ef94643218fff347f98842cb704598a83 Merge pull request #2780 from AdrianGaudebert/1144569-supersearch-columns-again Fixes bug 1144569 - Configurable returned columns for Super Search mi…
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Good news: this is in stage again, and doesn't seem to impact perfs in our stage ES cluster. It should be good to go to prod any time!
This commit originally happened after I made a lot of changes to our webapp (using SuperSearch for report/list/), so when I re-merged the commit without the changes to report/list/, a lot of conflicts arose. Mostly that was just dealing with unit tests.
Product: Socorro → Socorro Graveyard
You need to log in before you can comment on or make changes to this bug.