Closed Bug 1144577 Opened 11 years ago Closed 11 years ago

"More info..." link appears on permission prompt when it hasn't info

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)

Status:
VERIFIED FIXED
Milestone:
2.2 S9 (3apr)
Project Flags:
blocking-b2g 2.2+
Tracking Flags:
Tracking Status
b2g-v2.2 --- verified
b2g-master --- verified

People

(Reporter: jorgep, Assigned: jorgep)

References

Details

Attachments

(1 file, 1 obsolete file)

28946.html
384 bytes, text/html
timdream
: review+
bajaj
: approval-gaia-v2.2+
Details
When an permission prompt appears with information on the "More info..." link the DOM isn't hidden when we accept / deny the permission. On the next prompts the "More info..." link is shown even if it is empty.
Assignee: nobody → jpruden92
Status: NEW → ASSIGNED
Attached file 28946.html —
Attachment #8579217 - Flags: review?(timdream)
Comment on attachment 8579217 [details] 28946.html Thanks!
Attachment #8579217 - Flags: review?(timdream) → review+
Comment on attachment 8579213 [details] [review] [gaia] jpruden92:bug1144577-system > mozilla-b2g:master (the two attachments are pointing to the same pull request)
Attachment #8579213 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
status-b2g-master: --- → fixed
Target Milestone: --- → 2.2 S9 (3apr)
Nominating to 2.2 as bug 1144784 depends on it and has already been set with 2.2+ flag. Jorge, can you ask for the approval of this patch, please?
blocking-b2g: --- → 2.2?
status-b2g-v2.2: --- → affected
Flags: needinfo?(jpruden92)
This supposedly blocks bug 1144784 from uplift. Please nominate this for v2.2 approval in that case.
Comment on attachment 8579217 [details] 28946.html [Approval Request Comment] [Bug caused by] (feature/regressing bug #): When we show a permission prompt with content on the "More info..." link and we accept/deny it, we don't hide the link and on the next prompts the link appear even if it is empty. [User impact] if declined: The "More info..." link is going to be showed always even if it is empty. This is a problem for user experience. [Testing completed]: I've added an unit test to prove the functionality. [Risk to taking this patch] (and alternatives if risky): Minimal risk. One line of patch and 19 of tests. [String changes made]: None
Flags: needinfo?(jpruden92)
Attachment #8579217 - Flags: approval-gaia-v2.2?
Tested and working in: flame eng master Gecko-a2b428e Gaia-3970bcf Pending v2.2
blocking-b2g: 2.2? → 2.2+
Attachment #8579217 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Tested in 2.2 and working: flame eng v2.2 Gecko-6ea0017 Gaia-e59ac06.tgz
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: