Remove unused strings from xpinstallConfirm.properties

RESOLVED FIXED in mozilla39

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dao, Assigned: bkudryavtsev, Mentored)

Tracking

unspecified
mozilla39
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/extensions/xpinstallConfirm.properties

As far as I can tell, the installComplete, installCompleteTitle and error-203 strings are unused. We should remove them.
(Assignee)

Comment 1

3 years ago
Created attachment 8581027 [details] [diff] [review]
bug1144613_removeunusedstrings.diff
Attachment #8581027 - Flags: review?(bmcbride)

Comment 2

3 years ago
Hello! I would like to take on this for my first bug if it's still possible. Are there any mentors available?

Thanks.
(Reporter)

Comment 3

3 years ago
(In reply to John Kang from comment #2)
> Hello! I would like to take on this for my first bug if it's still possible.
> Are there any mentors available?
> 
> Thanks.

Looks like Boris was a few hours quicker than you, see comment 1.

Nobody is working on bug 1144782 at the moment, maybe you want to take a look at that. I'm mentoring that.
(Reporter)

Comment 4

3 years ago
Comment on attachment 8581027 [details] [diff] [review]
bug1144613_removeunusedstrings.diff

>-installButtonLabel=Install Now
>-
>-installComplete=Software Installation is complete. You will have to restart %S for changes to take effect.
>-installCompleteTitle=Installation Complete
>-
>-error-203=Error Installing Item
>+installButtonLabel=Install Now
>\ No newline at end of file

Hi Boris, this looks good, but please add back an empty line at the end of the file so that the "installButtonLabel=Install Now" line remains untouched.
Attachment #8581027 - Flags: review?(bmcbride) → review+
(Reporter)

Updated

3 years ago
Assignee: nobody → boriskk.work
(Assignee)

Comment 5

3 years ago
Created attachment 8581163 [details] [diff] [review]
rev2 - bug1144613_removeunusedstrings.diff
Attachment #8581027 - Attachment is obsolete: true
Attachment #8581163 - Flags: review?(bmcbride)
(Reporter)

Comment 6

3 years ago
Comment on attachment 8581163 [details] [diff] [review]
rev2 - bug1144613_removeunusedstrings.diff

Thanks!
Attachment #8581163 - Flags: review?(bmcbride) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 7

3 years ago
Dao,
Can you vouch me on Mozillians?

https://mozillians.org/en-US/u/bkudryavtsev/

Thanks!
(Reporter)

Comment 8

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/86ece202348a

(In reply to Boris Kudryavtsev [:bkudryavtsev] from comment #7)
> Dao,
> Can you vouch me on Mozillians?
> 
> https://mozillians.org/en-US/u/bkudryavtsev/
> 
> Thanks!

done :)
Keywords: checkin-needed
(Assignee)

Comment 9

3 years ago
Thank you!
https://hg.mozilla.org/mozilla-central/rev/86ece202348a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.