Closed Bug 1144613 Opened 5 years ago Closed 5 years ago
Remove unused strings from xpinstall
http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/extensions/xpinstallConfirm.properties As far as I can tell, the installComplete, installCompleteTitle and error-203 strings are unused. We should remove them.
Hello! I would like to take on this for my first bug if it's still possible. Are there any mentors available? Thanks.
(In reply to John Kang from comment #2) > Hello! I would like to take on this for my first bug if it's still possible. > Are there any mentors available? > > Thanks. Looks like Boris was a few hours quicker than you, see comment 1. Nobody is working on bug 1144782 at the moment, maybe you want to take a look at that. I'm mentoring that.
Comment on attachment 8581027 [details] [diff] [review] bug1144613_removeunusedstrings.diff >-installButtonLabel=Install Now >- >-installComplete=Software Installation is complete. You will have to restart %S for changes to take effect. >-installCompleteTitle=Installation Complete >- >-error-203=Error Installing Item >+installButtonLabel=Install Now >\ No newline at end of file Hi Boris, this looks good, but please add back an empty line at the end of the file so that the "installButtonLabel=Install Now" line remains untouched.
Attachment #8581027 - Flags: review?(bmcbride) → review+
Comment on attachment 8581163 [details] [diff] [review] rev2 - bug1144613_removeunusedstrings.diff Thanks!
Attachment #8581163 - Flags: review?(bmcbride) → review+
Dao, Can you vouch me on Mozillians? https://mozillians.org/en-US/u/bkudryavtsev/ Thanks!
https://hg.mozilla.org/integration/fx-team/rev/86ece202348a (In reply to Boris Kudryavtsev [:bkudryavtsev] from comment #7) > Dao, > Can you vouch me on Mozillians? > > https://mozillians.org/en-US/u/bkudryavtsev/ > > Thanks! done :)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.