1144613 - Remove unused strings from xpinstallConfirm.properties

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dão Gottwald [:dao]]

http://mxr.mozilla.org/mozilla-central/source/toolkit/locales/en-US/chrome/mozapps/extensions/xpinstallConfirm.properties

As far as I can tell, the installComplete, installCompleteTitle and error-203 strings are unused. We should remove them.

Comment 1

[Boris Kudryavtsev [:bkudryavtsev]]

Attachment: bug1144613_removeunusedstrings.diff

Comment 2

[John Kang]

Hello! I would like to take on this for my first bug if it's still possible. Are there any mentors available?

Thanks.

Comment 3

[Dão Gottwald [:dao]]

(In reply to John Kang from comment #2)
> Hello! I would like to take on this for my first bug if it's still possible.
> Are there any mentors available?
> 
> Thanks.

Looks like Boris was a few hours quicker than you, see comment 1.

Nobody is working on bug 1144782 at the moment, maybe you want to take a look at that. I'm mentoring that.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8581027 [details] [diff] [review]
bug1144613_removeunusedstrings.diff

>-installButtonLabel=Install Now
>-
>-installComplete=Software Installation is complete. You will have to restart %S for changes to take effect.
>-installCompleteTitle=Installation Complete
>-
>-error-203=Error Installing Item
>+installButtonLabel=Install Now
>\ No newline at end of file

Hi Boris, this looks good, but please add back an empty line at the end of the file so that the "installButtonLabel=Install Now" line remains untouched.

Comment 5

[Boris Kudryavtsev [:bkudryavtsev]]

Attachment: rev2 - bug1144613_removeunusedstrings.diff

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8581163 [details] [diff] [review]
rev2 - bug1144613_removeunusedstrings.diff

Thanks!

Comment 7

[Boris Kudryavtsev [:bkudryavtsev]]

Dao,
Can you vouch me on Mozillians?

https://mozillians.org/en-US/u/bkudryavtsev/

Thanks!

Comment 8

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/86ece202348a

(In reply to Boris Kudryavtsev [:bkudryavtsev] from comment #7)
> Dao,
> Can you vouch me on Mozillians?
> 
> https://mozillians.org/en-US/u/bkudryavtsev/
> 
> Thanks!

done :)

Comment 9

[Boris Kudryavtsev [:bkudryavtsev]]

Thank you!

Comment 10

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/86ece202348a