1144615 - Add playback rate selection to the animation inspector panel

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, defect)

Description

[Patrick Brosset <:pbro>]

When platform bug 1120339 gets resolved, we'll be able to control animations' playback rate via AnimationPlayer objects.
Which means we'll be able to expose this to devtools users through the animation inspector panel.

Comment 1

[Patrick Brosset <:pbro>]

When bug 1120339 is fixed, the UI will first need to check that the setPlaybackRate method exists on the actor (as the rest of the feature detection is done on the front-end).
Also, on top of adding a UI control to change the rate, this same control should correctly the current rate when the player widget is first displayed (the rate could have been changed in content prior to the widget being displayed).

Comment 2

[Patrick Brosset <:pbro>]

My plan is to add a small drop-down button next to the play/pause, rewind, fforward buttons. It would show the current rate, and on click would display a list of presets to choose from.

Comment 3

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: bz://1144615/pbrosset

/r/6527 - Bug 1144615 - 1 - Minor css fixes in animation panel
/r/6529 - Bug 1144615 - 2 - Adds a playbackRate selector widget to the animation panel
/r/6531 - Bug 1144615 - 3 - Tests for the playbackRate selection UI in the animation panel

Pull down these commits:

hg pull -r 483804d08a30525b728be61ddac41bef30c16715 https://reviewboard-hg.mozilla.org/gecko/

Comment 4

[Patrick Brosset <:pbro>]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd6a47b1193c

Comment 5

[Patrick Brosset <:pbro>]

Comment on attachment 8587290 [details]
MozReview Request: bz://1144615/pbrosset

/r/6527 - Bug 1144615 - 1 - Minor css fixes in animation panel
/r/6529 - Bug 1144615 - 2 - Adds a playbackRate selector widget to the animation panel
/r/6531 - Bug 1144615 - 3 - Tests for the playbackRate selection UI in the animation panel

Pull down these commits:

hg pull -r f806895ea2e94c9dc5b78f06f268283b9f55f309 https://reviewboard-hg.mozilla.org/gecko/

Comment 6

[Patrick Brosset <:pbro>]

Rebased changesets on top of latest fx-team.

Comment 7

[Brian Grinstead [:bgrins]]

https://reviewboard.mozilla.org/r/6527/#review5409

Ship It!

Comment 8

[Patrick Brosset <:pbro>]

Landed part 1: https://hg.mozilla.org/integration/fx-team/rev/2bb927ec6786

Comment 9

[Victor Porof [:vporof][:vp]]

I have no idea how to use mozreview. You damn kids and your new tools that I need to learn. 

Consider this an r+.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backing out the other animation inspector changes that landed prior to this made tests angry. Backed out to try to get things green again.
https://hg.mozilla.org/integration/fx-team/rev/f88ae43fbb9c

Comment 11

[Patrick Brosset <:pbro>]

Relanded part 1 to fx-team, which only contains a really minor html/css styling change to the animation panel and was not related to yesterday's backout.

https://hg.mozilla.org/integration/fx-team/rev/27301bf3af8c

Comment 12

[Patrick Brosset <:pbro>]

Thanks Victor for the code review.
Landed parts 2 and 3:

remote:   https://hg.mozilla.org/integration/fx-team/rev/a87115bb8c7a
remote:   https://hg.mozilla.org/integration/fx-team/rev/3add0bfa670f

Comment 13

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/27301bf3af8c
https://hg.mozilla.org/mozilla-central/rev/a87115bb8c7a
https://hg.mozilla.org/mozilla-central/rev/3add0bfa670f

Comment 15

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1144615 - 2 - Adds a playbackRate selector widget to the animation panel

Comment 16

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1144615 - 3 - Tests for the playbackRate selection UI in the animation panel

Comment 17

[Patrick Brosset <:pbro>]

Attachment: MozReview Request: Bug 1144615 - 1 - Minor css fixes in animation panel