Closed Bug 1144619 Opened 5 years ago Closed 5 years ago
X' is created in the wrong scope
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:36.0) Gecko/20100101 Firefox/36.0 Build ID: 20150306140126 Steps to reproduce: Location: line 297, column 13 Value stored to 'nextY' during its initialization is never read
OS: Linux → All
Hardware: x86 → All
Comment on attachment 8579295 [details] [diff] [review] patch.diff Please don't mix whitespace changes that reformat the whole file with substantive changes. (I'd be ok with a patch to remove trailing whitespace, but as a separate patch.)
Attachment #8579295 - Flags: review?(dbaron) → review-
OK. I put on this diff only the main modification that I made on this file (not the trailing space).
Comment on attachment 8579407 [details] [diff] [review] patch.diff Did you also mean to remove the assignments to nextX and nextY in between these two changes? (Without that removal it wouldn't compile.)
Attachment #8579407 - Flags: review?(dbaron) → review-
Sorry, I totaly forgot to remove the assignments that were before the new declaration. I fix it.
Attachment #8579567 - Flags: review?(dbaron) → review+
If you follow the instructions at: https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F you can upload a revised patch and add the checkin-needed keyword.
I upload the revised patch as expected.
Attachment #8579567 - Attachment is obsolete: true
Assignee: nobody → stephanichous
You need to log in before you can comment on or make changes to this bug.