Closed Bug 1144619 Opened 5 years ago Closed 5 years ago

Variable 'nextX' is created in the wrong scope

Categories

(Core :: XUL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: stephanichous, Assigned: stephanichous)

References

(Blocks 1 open bug)

Details

(Keywords: clang-analyzer, Whiteboard: [lang=cpp])

Attachments

(1 file, 3 obsolete files)

Attached patch patch.diff (obsolete) — Splinter Review
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150306140126

Steps to reproduce:

Location:	line 297, column 13
Value stored to 'nextY' during its initialization is never read
Mentor: mh+mozilla
Flags: a11y-review?
OS: Linux → All
Hardware: x86 → All
Whiteboard: [lang=c++]
Keywords: checkin-needed
Mentor: dbaron
Attachment #8579295 - Flags: review?(dbaron)
Flags: a11y-review?
Whiteboard: [lang=c++] → [lang=cpp]
Mentor: dbaron, mh+mozilla
Comment on attachment 8579295 [details] [diff] [review]
patch.diff

Please don't mix whitespace changes that reformat the whole file with substantive changes.

(I'd be ok with a patch to remove trailing whitespace, but as a separate patch.)
Attachment #8579295 - Flags: review?(dbaron) → review-
Attached patch patch.diff (obsolete) — Splinter Review
OK. I put on this diff only the main modification that I made on this file (not the trailing space).
Attachment #8579295 - Attachment is obsolete: true
Attachment #8579407 - Flags: review?(dbaron)
Comment on attachment 8579407 [details] [diff] [review]
patch.diff

Did you also mean to remove the assignments to nextX and nextY in between these two changes?  (Without that removal it wouldn't compile.)
Attachment #8579407 - Flags: review?(dbaron) → review-
Attached patch patch.diff (obsolete) — Splinter Review
Sorry, I totaly forgot to remove the assignments that were before the new declaration. I fix it.
Attachment #8579407 - Attachment is obsolete: true
Attachment #8579567 - Flags: review?(dbaron)
Attachment #8579567 - Flags: review?(dbaron) → review+
Attached patch patch.diffSplinter Review
I upload the revised patch as expected.
Attachment #8579567 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a77ec216cb3e
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.