Variable 'nextX' is created in the wrong scope

RESOLVED FIXED in Firefox 39

Status

()

Core
XUL
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Stéphane SCHMIDELY, Assigned: Stéphane SCHMIDELY)

Tracking

(Blocks: 1 bug, {clang-analyzer})

Trunk
mozilla39
clang-analyzer
Points:
---

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: [lang=cpp])

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

3 years ago
Created attachment 8579295 [details] [diff] [review]
patch.diff

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150306140126

Steps to reproduce:

Location:	line 297, column 13
Value stored to 'nextY' during its initialization is never read
(Assignee)

Updated

3 years ago
Mentor: mh+mozilla
Flags: a11y-review?
OS: Linux → All
Hardware: x86 → All
Whiteboard: [lang=c++]
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Updated

3 years ago
Mentor: dbaron
(Assignee)

Updated

3 years ago
Attachment #8579295 - Flags: review?(dbaron)
(Assignee)

Updated

3 years ago
Flags: a11y-review?
(Assignee)

Updated

3 years ago
Whiteboard: [lang=c++] → [lang=cpp]
(Assignee)

Updated

3 years ago
Mentor: dbaron, mh+mozilla
Comment on attachment 8579295 [details] [diff] [review]
patch.diff

Please don't mix whitespace changes that reformat the whole file with substantive changes.

(I'd be ok with a patch to remove trailing whitespace, but as a separate patch.)
Attachment #8579295 - Flags: review?(dbaron) → review-
Keywords: checkin-needed
(Assignee)

Comment 2

3 years ago
Created attachment 8579407 [details] [diff] [review]
patch.diff

OK. I put on this diff only the main modification that I made on this file (not the trailing space).
Attachment #8579295 - Attachment is obsolete: true
Attachment #8579407 - Flags: review?(dbaron)
Comment on attachment 8579407 [details] [diff] [review]
patch.diff

Did you also mean to remove the assignments to nextX and nextY in between these two changes?  (Without that removal it wouldn't compile.)
Attachment #8579407 - Flags: review?(dbaron) → review-
(Assignee)

Comment 4

3 years ago
Created attachment 8579567 [details] [diff] [review]
patch.diff

Sorry, I totaly forgot to remove the assignments that were before the new declaration. I fix it.
Attachment #8579407 - Attachment is obsolete: true
Attachment #8579567 - Flags: review?(dbaron)
Attachment #8579567 - Flags: review?(dbaron) → review+
If you follow the instructions at:
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
you can upload a revised patch and add the checkin-needed keyword.
(Assignee)

Comment 6

3 years ago
Created attachment 8580230 [details] [diff] [review]
patch.diff

I upload the revised patch as expected.
Attachment #8579567 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/a77ec216cb3e
Assignee: nobody → stephanichous
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a77ec216cb3e
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Keywords: clang-analyzer
Blocks: 712350
You need to log in before you can comment on or make changes to this bug.