1144687 - There are two mostly identical sample_data_generator.py files in the treeherder-service repo

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Ed Morley [:emorley]]

Let's combine them:

https://github.com/mozilla/treeherder-service/blob/master/tests/sample_data_generator.py

https://github.com/mozilla/treeherder-service/blob/master/tests/model/derived/sample_data_generator.py

Comment 1

[MikeLing]

Hello~ 

I'm interesting in this bug, could you tell me more detail about it? Thank you :)

These two file a almost same file, but where should I put after I combine them into a same file(int ...../tests/sample_data_generator or ...../tests/derived or other directory)?

Comment 2

[Ed Morley [:emorley]]

I'd keep the tests/sample_data_generator.py copy :-)

Comment 3

[MikeLing]

(In reply to Ed Morley [:emorley] from comment #2)
> I'd keep the tests/sample_data_generator.py copy :-)

Hm, is that means we can simply remove the "tests/model/derived/sample_data_generator.py"and change  "
from .sample_data_generator" to "from test.sample_data_generator"? Which is this line in here:

(https://github.com/mozilla/treeherder/blob/f5c0b53e0ce6b527c5eb2d861adeb72e1e5859ea/tests/model/derived/test_objectstore_model.py#L8)

Comment 4

[Ed Morley [:emorley]]

The PR in bug 1228458 fixes this (was silly to remove the unused functions from this file too, when the whole file could go).

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9b5c96e6ad2fbf99f5150b328fe5aa4ff0b84b38
Bug 1144687 - Remove duplicate sample_data_generator.py file

It's unused and mostly a dupe of the file in `tests/`.