Closed Bug 1144695 Opened 8 years ago Closed 8 years ago

make installers fails in mozharness desktop repacks

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox39 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox39 --- fixed

People

(Reporter: massimo, Assigned: massimo)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1144695 - Fix make installers errors in mozharness desktop repacks. r=gps
1.00 KB, patch
massimo
: review+
Details | Diff | Splinter Review
Attached patch fix for make installers.patch (obsolete) — — Splinter Review 
While testing mozharness desktop repacks, we hit this error (windows only)

...
c:/builds/moz2_slave/WINNT-5.2-ash-l10n-1_10-000000/build/ash/config/rules.mk:1235: *** target pattern contains no '%'.  Stop.
...

for some reasons, FINAL_TARGET is set to c:buildsmoz2_slaveWINNT-5.2-ash-l10n-1_10-000000buildashobj-l10ndist/bin
and make installers fails.

mshal wrote this patch, that solves the issue (tested on ash).

Before set the patch for review,  we need to run some extra tests to understand if this can create problems in other jobs (e.g current l10n nightlies repacks from mozilla-central)
Assignee: nobody → mgervasini
Blocks: 1144709
Attachment #8579394 - Flags: review?(gps)
Attachment #8579394 - Flags: review?(gps) → review+
re-created as a proper hg patch
Attachment #8579394 - Attachment is obsolete: true
Attachment #8581497 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/16fa3005386e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.