1144695 - make installers fails in mozharness desktop repacks

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Massimo Gervasini [:massimo]]

Attachment: fix for make installers.patch

While testing mozharness desktop repacks, we hit this error (windows only)

...
c:/builds/moz2_slave/WINNT-5.2-ash-l10n-1_10-000000/build/ash/config/rules.mk:1235: *** target pattern contains no '%'.  Stop.
...

for some reasons, FINAL_TARGET is set to c:buildsmoz2_slaveWINNT-5.2-ash-l10n-1_10-000000buildashobj-l10ndist/bin
and make installers fails.

mshal wrote this patch, that solves the issue (tested on ash).

Before set the patch for review,  we need to run some extra tests to understand if this can create problems in other jobs (e.g current l10n nightlies repacks from mozilla-central)

Comment 1

[Massimo Gervasini [:massimo]]

Tested on ash: nightly builds are fine.

https://treeherder.mozilla.org/#/jobs?repo=ash&revision=177b1fcf735d

Comment 2

[Massimo Gervasini [:massimo]]

Attachment: Bug 1144695 - Fix make installers errors in mozharness desktop repacks. r=gps

re-created as a proper hg patch

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16fa3005386e

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/16fa3005386e