1144829 - Edit bookmark from star

Status: RESOLVED DUPLICATE of bug 1232438

(Firefox for Android Graveyard :: General, defect)

Description

[Joni Lehto]

User Agent: Mozilla/5.0 (Android; Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
Build ID: 20150314003142

Steps to reproduce:

1. Saved a bookmark by tapping star in general menu
2. Got edit bookmark dialog
3. Typed in a description and saved
4. Wanted to change the description
5. Tried tapping the star


Actual results:

6. The bookmark got deleted (inconsistent with desktop Firefox)


Expected results:

6. The bookmark edit dialog should have opened with an option to delete the bookmark (same as on desktop)

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Anthony, any plans to implement bookmark-editing functionality?

Comment 2

[Joni Lehto]

Bookmark-editing functionality already exists and can be accessed directly after saving a new bookmark by tapping "Settings" in the on-screen confirmation message. The issue is that there seems to be no way to access it afterwards at any point.

Proposal: make tapping the star of an existing bookmark open the edit bookmark dialog instead of deleting the bookmark, and add a delete bookmark button into that dialog.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Joni Lehto from comment #2)
> Bookmark-editing functionality already exists and can be accessed directly
> after saving a new bookmark by tapping "Settings" in the on-screen
> confirmation message. The issue is that there seems to be no way to access
> it afterwards at any point.

I have a mock that triggers a custom dialog using system UI to edit Title and URL (maybe even add notes) but to your point, we already do that from the "option" on the super toast.

To help me better understand this problem, can you tell me what you'd like to edit precisely when you're bookmarking on Mobile in your use-case?

> Proposal: make tapping the star of an existing bookmark open the edit
> bookmark dialog instead of deleting the bookmark, and add a delete bookmark
> button into that dialog.

Perhaps, but I really want to try and preserve the easy of "one-touch" bookmarking. That's why we've reserved functionality like "edit" for the long-press function on the Bookmarks Panel. This is also consistent with the rest of our Panel's UX.

Comment 4

[Joni Lehto]

(In reply to Anthony Lam (:antlam) from comment #3)
> I have a mock that triggers a custom dialog using system UI to edit Title
> and URL (maybe even add notes) but to your point, we already do that from
> the "option" on the super toast.

What's the "super toast"?

> To help me better understand this problem, can you tell me what you'd like
> to edit precisely when you're bookmarking on Mobile in your use-case?

The title.

> I really want to try and preserve the easy of "one-touch" bookmarking. That's
> why we've reserved functionality like "edit" for the long-press function on
> the Bookmarks Panel. This is also consistent with the rest of our Panel's UX.

Had not noticed the bookmark tab (panel?) in the new tab view. Through it it's possible to edit a bookmark without deleting it, which is good. However, it's inconvenient to have to open a new tab, change the tab (panel?) and search in order to edit the bookmark for the page you're currently on.

If you could make the edit dialog for the current page openable also by long-pressing the star, that would be more convenient without affecting the single-tap functionality of removing a bookmark.

Comment 5

[Andrzej Hunt :ahunt]

There's some more discussion of this over at Bug 1232438, Marking this one as duplicate!