1144871 - Improve FileAccessor API

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect)

Description

[Brian Nicholson (:bnicholson)]

There are several quirks with our FileAccessor/ProfileFileAccessor implementation:
* basePath is an unnecessary (and unused) parameter in several methods, where we fall back to the profile directory. If we pass in another basePath, the operations won't even happen inside of the profile, which I'd argue shouldn't happen in ProfileFileAccessor.
* Errors are swallowed up. We can forward NSErrorPointer so the caller decides what to do with it.
* A number of methods have some unexpected side effects. For example, remove(), get(), and exists() will all create directories if the directory doesn't exist.

We should keep this API as simple and straightforward as possible, and keep it well-documented. We don't want to end up with another Profile mess like we had on Android!

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Pull request

Comment 2

[Nick Alexander :nalexander [he/him] (PTO until Monday, July 28)]

Comment on attachment 8579613 [details] [review]
Pull request

Stream of consciousness comments on the PR, but this looks basically OK to me.