1144975 - Video dimensions for tab mirroring can be smaller than the devices display

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Randall Barker [:rbarker]]

When generating a tab mirror video stream, the stream can be half the size of the target display (currently 720p for Roku). This appears to be caused by the fact that the device pixel ratio is not used in calculating the desired video dimensions.

Comment 1

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1144975-Video-dimensions-for-tab-mirroring-can-be-smaller-than-the-devices-display-15031817-51bce32.patch

Comment 2

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1144975-Video-dimensions-for-tab-mirroring-can-be-smaller-than-the-devices-display-15031818-d23f8f8.patch

Comment 3

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1144975-Video-dimensions-for-tab-mirroring-can-be-smaller-than-the-devices-display-15031818-5b3646a.patch

Comment 4

[Randall Barker [:rbarker]]

Attachment: 0001-Bug-1144975-Video-dimensions-for-tab-mirroring-can-be-smaller-than-the-devices-display-15031914-0c931d0.patch

Comment 5

[Randall Barker [:rbarker]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a49ef156a37

Comment 6

[Randall Barker [:rbarker]]

Comment on attachment 8580285 [details] [diff] [review]
0001-Bug-1144975-Video-dimensions-for-tab-mirroring-can-be-smaller-than-the-devices-display-15031914-0c931d0.patch

I was told you looked over the original version. Could you take a look at this patch to see if there are any incorrect assumptions with regard to pixel conversions?

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8580285 [details] [diff] [review]
0001-Bug-1144975-Video-dimensions-for-tab-mirroring-can-be-smaller-than-the-devices-display-15031914-0c931d0.patch

Review of attachment 8580285 [details] [diff] [review]:
-----------------------------------------------------------------

I'm lacking context to review this properly but the coordinate system stuff in the patch looks ok to me.

Comment 8

[Randall Barker [:rbarker]]

Comment on attachment 8580285 [details] [diff] [review]
0001-Bug-1144975-Video-dimensions-for-tab-mirroring-can-be-smaller-than-the-devices-display-15031914-0c931d0.patch

Double checked values for both desktop and mobile with and with out patch applied.

Desktop without: Width: 1164 Height: 718
Desktop with:    Width: 1166 Height: 720

Mobile without:  Width: 384 Height: 566
Mobile with:     Width: 486 Height: 720

The difference in desktop is due to the original algorithm requiring the width be a multiple of 4 which appears to no longer be an issue. the difference in Mobile is due to the fact that the width and height were not scaled by the screen pixel ratio.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/b45c9c38c9dc

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b45c9c38c9dc