1145029 - AMD GPU's have issues with 4k video

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Bug 1131638 implemented a fallback to software decoding when we detect that frames are being corrupted.

Since we know that basically all AMD cards have problems with 4k video, we should just disable this and avoid blocking hardware decoding for other resolutions.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: disable-hw-accel-4k

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8579846 [details] [diff] [review]
disable-hw-accel-4k

Review of attachment 8579846 [details] [diff] [review]:
-----------------------------------------------------------------

Should make SupportsSharedDecoders const.

::: dom/media/fmp4/PlatformDecoderModule.h
@@ +138,5 @@
>    virtual void DisableHardwareAcceleration() {}
>  
> +  virtual bool SupportsSharedDecoders(const mp4_demuxer::VideoDecoderConfig& aConfig) {
> +    return true;
> +  }

should make this member const

::: dom/media/fmp4/wmf/WMFDecoderModule.h
@@ +41,5 @@
>    {
>      sDXVAEnabled = false;
>    }
>  
> +  virtual bool SupportsSharedDecoders(const mp4_demuxer::VideoDecoderConfig& aConfig) MOZ_OVERRIDE;

const

Comment 3

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/117a35077c1b

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8579846 [details] [diff] [review]
disable-hw-accel-4k

Approval Request Comment
[Feature/regressing bug #]: HTML5 Video
[User impact if declined]: Attempting 4k video will disable h/w accel for all videos for the rest of the session for AMD users.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Not a huge deal, but will improve user experience if users attempt 4k video.
[String/UUID change made/needed]: None

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8579846 [details] [diff] [review]
disable-hw-accel-4k

I spoke with cpearce about this patch. The patch makes us take a well tested software path over a buggy driver hardware path. We'll take this in b7. Beta+ Aurora+

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2445fcfe99d4

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d95e5e43ea20

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/117a35077c1b