AMD GPU's have issues with 4k video

RESOLVED FIXED in Firefox 37

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

(Depends on 1 bug)

29 Branch
mozilla39
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox37 fixed, firefox38 fixed, firefox39 fixed)

Details

Attachments

(1 attachment)

Bug 1131638 implemented a fallback to software decoding when we detect that frames are being corrupted.

Since we know that basically all AMD cards have problems with 4k video, we should just disable this and avoid blocking hardware decoding for other resolutions.
Attachment #8579846 - Flags: review?(jyavenard)
Depends on: 1145030
Comment on attachment 8579846 [details] [diff] [review]
disable-hw-accel-4k

Review of attachment 8579846 [details] [diff] [review]:
-----------------------------------------------------------------

Should make SupportsSharedDecoders const.

::: dom/media/fmp4/PlatformDecoderModule.h
@@ +138,5 @@
>    virtual void DisableHardwareAcceleration() {}
>  
> +  virtual bool SupportsSharedDecoders(const mp4_demuxer::VideoDecoderConfig& aConfig) {
> +    return true;
> +  }

should make this member const

::: dom/media/fmp4/wmf/WMFDecoderModule.h
@@ +41,5 @@
>    {
>      sDXVAEnabled = false;
>    }
>  
> +  virtual bool SupportsSharedDecoders(const mp4_demuxer::VideoDecoderConfig& aConfig) MOZ_OVERRIDE;

const
Attachment #8579846 - Flags: review?(jyavenard) → review+
Comment on attachment 8579846 [details] [diff] [review]
disable-hw-accel-4k

Approval Request Comment
[Feature/regressing bug #]: HTML5 Video
[User impact if declined]: Attempting 4k video will disable h/w accel for all videos for the rest of the session for AMD users.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Not a huge deal, but will improve user experience if users attempt 4k video.
[String/UUID change made/needed]: None
Attachment #8579846 - Flags: approval-mozilla-beta?
Attachment #8579846 - Flags: approval-mozilla-aurora?
Comment on attachment 8579846 [details] [diff] [review]
disable-hw-accel-4k

I spoke with cpearce about this patch. The patch makes us take a well tested software path over a buggy driver hardware path. We'll take this in b7. Beta+ Aurora+
Attachment #8579846 - Flags: approval-mozilla-beta?
Attachment #8579846 - Flags: approval-mozilla-beta+
Attachment #8579846 - Flags: approval-mozilla-aurora?
Attachment #8579846 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/117a35077c1b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.