1145059 - [RTL][Dialer]The MIC button and hide keypad button are swapped.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Sue]

Attachment: MIC_Dialer_button.png

[1.Description]:
[RTL][v2.2 & v3.0][Dialer]The MIC button and hide keypad button are swapped, with MIC icon shown at right of END button, and hide keypad button shown at left of END button.
See attachment:MIC_Dialer_button.png

[2.Testing Steps]: 
1. Set system language as Arabic.
2. Launch Dialer.
3. Call out to 911.
4. Tap dialer button to invoke the numeric keypad.
5. Observe the buttons at bottom of numeric keypad.

[3.Expected Result]: 
5. The MIC button and hide keypad button should remain same position as that in LTR language.

[4.Actual Result]: 
5. The MIC button and hide keypad button changed their position.

[5.Reproduction build]: 
Flame 2.2 build: affected
Build ID               20150318002504
Gaia Revision          306772a58335ac4cad285d27c3805090a8cc6886
Gaia Date              2015-03-17 17:12:36
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a6f5f4035ea5
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150318.040534
Firmware Date          Wed Mar 18 04:05:45 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build: affected
Build ID               20150318055750
Gaia Revision          b8051d370ddf4e5bd8e7d8a19fb9eeb5fd6ffb39
Gaia Date              2015-03-18 07:48:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/41a61514461e
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150318.093634
Firmware Date          Wed Mar 18 09:36:44 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Buttons should not be swapped as per RTL specs. This is inconsistent with the rest of RTL behavior and an often used screen so nominating

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comms triage: It's also inconsistent with the other panel of the call screen. Blocking.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] DouglasSherk:1145059-callscreen-rtl-toolbar > mozilla-b2g:master

Comment 4

[Doug Sherk (:drs) (inactive)]

Attachment: Set Callscreen keypad's toolbar to be always LTR.

Comment 5

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8582416 [details] [diff] [review]
Set Callscreen keypad's toolbar to be always LTR.

I'm glad it was this easy :)

Comment 6

[Doug Sherk (:drs) (inactive)]

Needinfo for uplift request.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/08d5150898813df07a90fa570fbedb68fe134872

Comment 8

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8582416 [details] [diff] [review]
Set Callscreen keypad's toolbar to be always LTR.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): None.
[User impact] if declined: Keypad and mic buttons in the Callscreen keypad view will be swapped in RTL mode.
[Testing completed]: I tested this, it's been on master for a day.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: None.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/f7b2676a3c3519d694ac9fdfac74276d1d8799e5

Comment 10

[Sue]

Attachment: MIC_Dialer_button.png

This issue has been verified successfully on latest build of Flame 2.2/3.0 with same steps in comment 0. The MIC button and hide keypad button remain same position as that in LTR language.
See attachment:MIC_Dialer_button.png
Rate:
Flame 2.2: 0/5
Flame 3.0: 0/5
Device: Flame 2.2 (pass)
Build ID               20150325162500
Gaia Revision          2d42a7c1d99472780e3aeb2e16d7cb0a4adbd222
Gaia Date              2015-03-25 20:46:52
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ebb742bfe1a4
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150325.200218
Firmware Date          Wed Mar 25 20:02:30 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (pass)
Build ID               20150325160204
Gaia Revision          508b8d48fb5ecf08bf0e5b4fef42bc48b770e7f2
Gaia Date              2015-03-25 16:54:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f40ee067d081
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150325.191758
Firmware Date          Wed Mar 25 19:18:07 EDT 2015
Bootloader             L1TC000118D0