Allow collapsing and expanding Synced (Remote) Tabs clients

RESOLVED DUPLICATE of bug 1345279

Status

()

RESOLVED DUPLICATE of bug 1345279
4 years ago
a year ago

People

(Reporter: nalexander, Unassigned, Mentored)

Tracking

(Blocks: 1 bug)

unspecified
All
iOS

Firefox Tracking Flags

(fxios+)

Details

(Whiteboard: [nicetohave])

Attachments

(2 attachments)

Duplicate of the functionality on Android.  See tecgirl's beautiful screenshot:

http://cl.ly/aHie

There are few parts to this.  We need to:

* add and persist state for whether a client is collapsed;
* draw the appropriate arrows in the header views;
* add the interaction and animations for expanding and collapsing.

Mentor bug!
(Reporter)

Updated

4 years ago
Blocks: 1157383
(Reporter)

Updated

4 years ago
No longer blocks: 1130495

Comment 1

3 years ago
I've been working on this. Can I officially take the bug?
Absolutely!
Assignee: nobody → allmacosx24
Status: NEW → ASSIGNED
:BigxMac Where are we at with this? I was just filing a fresh bug for it.

Slightly updated mock: https://invis.io/EC2U2YZB4
Flags: needinfo?(allmacosx24)
tracking-fxios: --- → ?
tracking-fxios: ? → 1.1+
Unassigning due to inactivity. BigxMac, feel free to take again if you're working on it.
Assignee: allmacosx24 → nobody
Status: ASSIGNED → NEW
Created attachment 8647695 [details]
syncCaret.zip

Updated

3 years ago
Assignee: nobody → bmunar
in da process of a fix!

Updated

3 years ago
Status: NEW → ASSIGNED
Whiteboard: [nicetohave]
Created attachment 8652492 [details] [review]
PR - make bnicholz fix the rest // my parting gift

TODOs:

1. make the caret animation and placement UI-approved
2. make sure the offset doesn't screw up where the user is on the tabs panel (aka when a row is collapsed, the tableView doesn't scroll down 16 rows or whatever).
3. It crashes when you press the caret after the initial pull to refresh; after that, it doesn't crash anymore.
Attachment #8652492 - Flags: ui-review?(randersen)
Attachment #8652492 - Flags: review?(bnicholson)
Comment on attachment 8652492 [details] [review]
PR - make bnicholz fix the rest // my parting gift

Two nits:

1) The caret is vertically-bottom aligned. Please vertically-center align it.
2) Add a bottom border to the headers so when they are collapsed they don't bleed together. The border we use on the History panel headers (Today, Yesterday, etc.) for time would be perfect.
Flags: needinfo?(allmacosx24)
Assignee: brymunar → bnicholson
Comment on attachment 8652492 [details] [review]
PR - make bnicholz fix the rest // my parting gift

Removing review flag since there's a good amount of work left outlined in comment 7 and comment 8.
Attachment #8652492 - Flags: ui-review?(randersen)
Attachment #8652492 - Flags: review?(bnicholson)
tracking-fxios: 1.1+ → 2.0+
Assignee: bnicholson → nobody
Status: ASSIGNED → NEW
tracking-fxios: 2.0+ → +
OS: iOS 8 → iOS
Rank: 7
PR became dormant: https://github.com/mozilla/firefox-ios/pull/943

Closed for now but can be reopened if we plan on coming back to this feature.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1345279
You need to log in before you can comment on or make changes to this bug.