Make tab tray home panel icon list have light background and update icons

RESOLVED FIXED

Status

()

Firefox for iOS
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Per mock at

http://cl.ly/aHie

This will help our tab tray animation feel much better when coming from and going to the about:home page.  Right now we have a dark bar that can pop awkwardly.  In general, the new looks feels lighter and cleaner -- more in keeping with our overall aesthetic.
(Assignee)

Comment 1

3 years ago
tecgirl: over to you for assets.
Flags: needinfo?(randersen)
Created attachment 8580234 [details]
panelIcons.zip

assets attached. also included are the active states. note we're not putting settings in this panel but we are putting sync.
Flags: needinfo?(randersen)
(Assignee)

Updated

3 years ago
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Created attachment 8580293 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/241

tecgirl: before:

https://www.dropbox.com/s/bkc3mvl5apj12y9/Screenshot%202015-03-19%2010.04.53.png?dl=0

after:

https://www.dropbox.com/s/ocb7ebyy0s95qpq/Screenshot%202015-03-19%2014.34.34.png?dl=0

The bottom border doesn't look great -- instructions (or PRs) gratefully accepted.
Flags: needinfo?(randersen)
Attachment #8580293 - Flags: review?(bnicholson)
Attachment #8580293 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 4

3 years ago
https://github.com/mozilla/firefox-ios/commit/3f1c83fe85d58a3c88e91f05c25951f406844b8a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
:nalexander, I'm not thrilled about the border but it will have to do for now.
Flags: needinfo?(randersen)
You need to log in before you can comment on or make changes to this bug.