Closed Bug 1145366 Opened 5 years ago Closed 5 years ago

IPC Proxy for HyperLink

Categories

(Core :: Disability Access APIs, defect)

36 Branch
x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(2 files)

Attached patch v1Splinter Review
This is a bit ugly, but I tried to follow the existing style where it is quite
strongly checked that the thing is a link.
Attachment #8580298 - Flags: review?(tbsaunde+mozbugs)
Attachment #8580298 - Flags: review?(tbsaunde+mozbugs) → review+
Comment on attachment 8580298 [details] [diff] [review]
v1

actually this doesn't work, AtkObject and AtkHyperlink are different objects.  So what you need to do is first make MaiHyperlink sotre either an accessible* or a Proxy* and make nsMaiInterfaceHyperlinkImpl.cpp deal with proxies.  Then you can make this stuff work by grabing the MaiHyperlink like the current code does but use the pointer has to get at a proxy.
Attachment #8580298 - Flags: review+ → review-
Ok, I don't know how to make that work.
Attached patch no atkSplinter Review
Attachment #8581841 - Flags: review?(tbsaunde+mozbugs)
Blocks: 1146518
Comment on attachment 8581841 [details] [diff] [review]
no atk

>+DocAccessibleChild::RecvStartOffset(const uint64_t& aID,
>+                                    uint32_t* aRetVal,
>+                                    bool* aOk)
>+{

I think the extra checking is unneccessary, the link interface should only be exposed if IsLink() returns true, and It can kind of be wrong in that it can say false when the accessible went away.  However istm handling the cases of method called on dead accessible and called on wrong type differently doesn't make much sense.  So this is certainly fine for now and we'll so how it turns out.
Attachment #8581841 - Flags: review?(tbsaunde+mozbugs) → review+
Assignee: nobody → bugs
https://hg.mozilla.org/mozilla-central/rev/a90178826816
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.