1145394 - Ensure all JS in m-c is parseable

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I would like to be able to parse all .js and .jsm files in the tree. The patches in here make that happen.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: Use AppConstants in prefs code

The way we were using the preprocessor in these two files (with comments interleaved) was messing up my broken preprocessing code. This patch switches these two cases to use AppConstants.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: Fix code that is broken or unused

This code must be unused or something. It's not syntactically correct. This patch fixes it.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: Remove executable permission from some js files

Having the executable bit set on these JS files is screwing up my heuristics for finding JS code. There's no reason for these files to be executable, so I think we should turn it off.

Fabrice, can you "review" the DOM changes and Gavin the rest?

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 8580328 [details] [diff] [review]
Remove executable permission from some js files

Not sure how that happened in the first place!

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8580326 [details] [diff] [review]
Fix code that is broken or unused

Can you file a bug on removing CRH_DIALOG_TREE_VIEW-related code?

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/8626a98a34d8
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f7c5c5c8bdff
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/72c740d37eb9

Filed bug 1145735 for CRH_DIALOG_TREE_VIEW.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Rev 8626a98a34d8 backed out for mochitest-bc exceptions.
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ff3c70a5ad2

https://treeherder.mozilla.org/logviewer.html#?job_id=7865945&repo=mozilla-inbound

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Oh, looks like there are a bunch of other #ifdefs in applications.js...

Comment 9

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Oops. These files are actually pretty hard cases for eliminating the preprocessor since they use #expand and HAVE_SHELL_SERVICE (not sure what that is). I'll re-land when I can but leave the * annotations in the jar.mn files.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

HAVE_SHELL_SERVICE is basically trying to exclude MOZ_WIDGET_QT (and maybe OS2 and other non-supported things), so AppConstants.platform won't quite work. We might be able to just get rid of it entirely.

For the #expands its easy enough to add MOZ_APP_NAME and MOZ_MACBUNDLE_NAME to AppConstants.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

(Don't need to chase those in this bug, certainly.)

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f7c5c5c8bdff
https://hg.mozilla.org/mozilla-central/rev/72c740d37eb9

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e8c963fce3ff1e9011d8931d1acc68b9703991f1
Bug 1145394 - Fix unparseable JS code (r=gavin)

Comment 14

[Dave Townsend [:mossop]]

I accidentally clobbered the addon-sdk part of this when I landed bug 1146943 today so relanded as https://hg.mozilla.org/integration/fx-team/rev/692ec0a78180.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/692ec0a78180

Comment 16

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72859482261b

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/72859482261b