114541 - Preferences->labels has two title boxes

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Andreas Premstaller]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.6+)
Gecko/20011210
BuildID:    2001121003

The Labels panel in preferences has one header-box too much and the title is
written in the lower (wrong) box.

Reproducible: Always
Steps to Reproduce:
1. Open pref->mail->labels

Actual Results:  Two header boxes, title in the wrong one. 

Here comes a path that also makes the pref-panel a </page> instead of a
</window> (like the other pref-panels).

Comment 1

[Andreas Premstaller]

Attachment: patch, uses </page>, title in the correct (only) box

ssu, could you please review and suggest somebody to sr, checkin?

Comment 2

[Andreas Premstaller]

adding keywords, sorry for the spam.

Comment 3

[Blake Ross]

Comment on attachment 61206 [details] [diff] [review]
patch, uses </page>, title in the correct (only) box

sr=blake if you remove xmlns:html and class="color-dialog"

Comment 4

[Andreas Premstaller]

Attachment: updated patch according to blake's comment

Comment 5

[Sean Su]

Attachment: image of patch

your patch will make the title box disappear.  However, if you remove:
  headertitle="&pane.title;">

and add back:
  <hbox class="box-smallheader" title="&pane.title;"/>

it should fix the problem.

Comment 6

[Andreas Premstaller]

Attachment: what I see...

Sean, the problem I see are infact two title boxes (see screenshot). I see this
on W2K using 20011210-03 and have verified it on a Mac using build 20011210-16.
Could you please re-verify this, eventually on a different machine?

Comment 7

[Sean Su]

Comment on attachment 61211 [details] [diff] [review]
updated patch according to blake's comment

I didn't see the two titles until I was trying to verify your fix.  I'm
guessing that mozilla kept picking up the cached version.

I applied your second patch and got the image I attached.  I then removed the
headertitle= and added back the 'box-smallheader' line, and a single title
appeared.

I just noticed that blake made some changes to all the pref files.  I have a
tree that's from late last week before he made the changes, which explains why.

Your second patch actually looks good.

r=ssu

Comment 8

[Sean Su]

patch checked in.  Thanks Andreas.

Comment 9

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2002.01.07.0x comm bits on linux rh7.2, winnt and mac 10.1.2.