1145440 - Ship constant names for strategy and outcomes instead of the slightly longer form debugging strings

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Shu-yu Guo [:shu]]

e.g., ship "GetProp_Constant" over "getprop constant" and "NotObject" over "not definitely an object"

Jordan convinced me that both are equally cryptic, and the constant names would make it clear that it's an unchanging string and is internal.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Ship constant names for tracked strategy and outcomes in the profile JSON instead of slightly longer form strings.

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 8580396 [details] [diff] [review]
Ship constant names for tracked strategy and outcomes in the profile JSON instead of slightly longer form strings.

Review of attachment 8580396 [details] [diff] [review]:
-----------------------------------------------------------------

So the idea here is that the frontend will have a mapping from the names to appropriate "long-form" strings?

Comment 3

[Shu-yu Guo [:shu]]

(In reply to Kannan Vijayan [:djvj] from comment #2)
> Comment on attachment 8580396 [details] [diff] [review]
> Ship constant names for tracked strategy and outcomes in the profile JSON
> instead of slightly longer form strings.
> 
> Review of attachment 8580396 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> So the idea here is that the frontend will have a mapping from the names to
> appropriate "long-form" strings?

I think we agreed that the constant names won't be localized and will be displayed as is.

I think the idea will be to use these constant names as links to some MDN page in the "raw" view (vs the "suggestions" view, once we have such a thing) that briefly explains these optimizations.

We talked about wanting to do that anywhow, the documentation on MDN.

Comment 4

[Kannan Vijayan [:djvj]]

Comment on attachment 8580396 [details] [diff] [review]
Ship constant names for tracked strategy and outcomes in the profile JSON instead of slightly longer form strings.

Review of attachment 8580396 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds reasonable.

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8bd7b499e291