1145542 - [RTL][Calendar]The ellipsis is displayed at left side of title and location of an event which has LTR characters in Day, Week and Month views.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P2)

Description

[Lancy(Leave from Mozilla)]

Attachment: Screenshot_event.png

[1.Description]:
[RTL][v2.2&v3.0][Calendar] If we create an event which has long LTR title and location, the ellipsis is displayed at left side of title and location in Day, Week and Month views.
See attachment:Screenshot_event.png

[2.Testing Steps]: 
1.Launch Calendar and create an event which has long LTR title and long LTR location.
2.Observe the event in Day, Week and Month views.

[3.Expected Result]: 
2.The ellipsis should be displayed at right side of title and location.

[4.Actual Result]: 
2.The ellipsis is displayed at left side of title and location.

[5.Reproduction build]: 
Flame 2.2 build (Affected):
Build ID               20150319002500
Gaia Revision          9043c11f699c15bb6072422d1dad6518d1b5ddda
Gaia Date              2015-03-19 01:40:44
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c0442d170bec
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150319.042028
Firmware Date          Thu Mar 19 04:20:38 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build (Affected):
Build ID               20150319160212
Gaia Revision          c39e15f631de80c69467fda0d4ea0bcda9e194ca
Gaia Date              2015-03-18 19:30:04
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cbd0efcd976c
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150319.193329
Firmware Date          Thu Mar 19 19:33:42 EDT 2015
Bootloader             L1TC000118D0
[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free Test

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Triage -- P2. Nominating since I can imagine that people would attend LTR-named events and this would be an issue (just an example)

Comment 2

[Tamara Hills [:thills]]

Potentially helpful PR for fixing this:  https://github.com/mozilla-b2g/gaia/pull/28976/files

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] millermedeiros:1145542-rtl-event-ellipsis > mozilla-b2g:master

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8581907 [details] [review]
[gaia] millermedeiros:1145542-rtl-event-ellipsis > mozilla-b2g:master

LGTM!

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/81884e20ea6babbd7a4ececdc75bb37c9f3ef173

Comment 6

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8581907 [details] [review]
[gaia] millermedeiros:1145542-rtl-event-ellipsis > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: ellipsis at the wrong side for bidi text and will also have overlaps with the alarm icon on day view
[Testing completed]: manual
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/d225db9622d6e308af02880f43628dcf2f3f9bbe

Comment 8

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed in the latest Nightly Flame 2.2 build.

Actual Results: Event names and places correctly have the ellipsis on the right for LTR text when in an RTL language.

Environmental Variables:
Device: Flame 2.2
BuildID: 20150325002503
Gaia: aeee2a54caa8ffb875b96264b61d742b70689f22
Gecko: 556aca3e50ac
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

This issue is NOT fixed in the latest Nightly Flame 3.0 build.

Actual Results: Event names and places incorrectly have the ellipsis on the left for LTR text when in an RTL language.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150325083046
Gaia: aebfbd998041e960cea0468533c0b5041b504850
Gecko: db0409de517a
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 9

[Sue]

Attachment: correct_ellipsis.png

This issue is verified successfully on the latest build of Flame 3.0 with same steps in comment 0. When we create an event which has long LTR title and LTR location, the ellipsis is displayed at right side of LTR text in Day, Week and Month views.
See attachment:correct_ellipsis.png
Rate:0/5

Device: Flame 3.0(pass)
Build ID               20150325160204
Gaia Revision          508b8d48fb5ecf08bf0e5b4fef42bc48b770e7f2
Gaia Date              2015-03-25 16:54:53
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f40ee067d081
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150325.191758
Firmware Date          Wed Mar 25 19:18:07 EDT 2015
Bootloader             L1TC000118D0

Comment 10

[Sue]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/16229/