1145604 - 'close tab' action not discoverable

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Jenn Chaulk (:jchaulk)]

Users having trouble with discoverability of ‘close tab’ action.  Expecting an X, and not just the swipe action.

Comment 1

[Sachin Irukula]

Added close tab action with an X at the top right of the tab https://github.com/mozilla/firefox-ios/pull/259 let me know your opinion.

Comment 2

[Sachin Irukula]

(In reply to Sachin Irukula from comment #1)
> Added close tab action with an X at the top right of the tab
> https://github.com/mozilla/firefox-ios/pull/259 let me know your opinion.

Sorry wrong link please refer to https://github.com/mozilla/firefox-ios/pull/290

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: Pull request

This looks pretty good, with some comments in the PR. Adding feedback? for Darrin and Robin in case they want to offer some polish suggestions now for the close image/margins/animation. Otherwise, I can file a separate follow-up after this lands.

Comment 4

[Darrin Henein [:darrin]]

Comment on attachment 8586459 [details] [review]
Pull request

This looks fine to me! May need some polish once the collection view stuff lands (and a dedicated asset) but im fine to land as-is and do those as followups.