1145661 - Video playback statistics are not working

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Diego Wilson [:diego]]

Video playback statistics where added in bug 948095.

The video app is supposed to output the following statistics to the console when media.mediasource.enabled is set to true:

I/GeckoDump( 1174): Video statistics start
I/GeckoDump( 1174): Dimensions: 640x480
I/GeckoDump( 1174): Complete duration: 00:45
I/GeckoDump( 1174): Start time: 00:00
I/GeckoDump( 1174): End time: 00:01
I/GeckoDump( 1174): Total frames: 61
I/GeckoDump( 1174): Decoded frames: 60
I/GeckoDump( 1174): Corrupted frames: 1
I/GeckoDump( 1174): Rendered frames: 54
I/GeckoDump( 1174): Dropped frames: 7
I/GeckoDump( 1174): Average rendered FPS: 22.84
I/GeckoDump( 1174): Video statistics end

As per https://github.com/mozilla-b2g/gaia/blob/master/apps/video/js/video.js#L1195

Comment 1

[Hema Koka [:hema]]

Russ,

Please investigate and if this is an issue on getting the stats from the media platform side for video app, NI Sotaro or Chris pearce.

Thanks
Hema

Comment 2

[Dave Hylands [:dhylands]]

Does this really need to block? I see zero user impact.

Comment 3

[Diego Wilson [:diego]]

(In reply to Dave Hylands [:dhylands] from comment #2)
> Does this really need to block? I see zero user impact.

This is needed to take performance metrics to ensure the quality of video playback.

Comment 4

[Russ Nicoletti [:russn]]

I've set 'media.mediasource.enabled' to '1' and to 'true' but I'm seeing that 'getVideoPlaybackQuality' is not available on the video element. I'm using 'setprop media.mediasource.enabled 1' and then I'm restarting b2g. Is that correct?

Comment 5

[Russ Nicoletti [:russn]]

I also tried adding 'user_pref("media.mediasource.enabled", true)' to prefs.js

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Try setting pref media.mediasource.whitelist to false.

Comment 7

[Sotaro Ikeda [:sotaro]]

From the following, the exposure of getVideoPlaybackQuality() seems to be controlled by MediaSource::Enabled().

partial interface HTMLVideoElement {
  [Func="mozilla::dom::MediaSource::Enabled", NewObject]
  VideoPlaybackQuality getVideoPlaybackQuality();

https://dxr.mozilla.org/mozilla-central/source/dom/webidl/HTMLVideoElement.webidl#51

Comment 8

[Sotaro Ikeda [:sotaro]]

On master, it checks "media.mediasource.enabled" and "media.mediasource.whitelist".

https://dxr.mozilla.org/mozilla-central/source/dom/media/mediasource/MediaSource.cpp#339

But on b2g v2.2, it checks "media.mediasource.enabled" and "media.mediasource.youtubeonly".

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/file/263d9f75db72/dom/media/mediasource/MediaSource.cpp

Comment 9

[Sotaro Ikeda [:sotaro]]

Then on master, the following enable the statistics.

> pref("media.mediasource.enabled", true);
> pref("media.mediasource.whitelist", false);

Comment 10

[Russ Nicoletti [:russn]]

I've verified that after setting the above prefs, the video app is dumping the video statistics:

I/GeckoDump( 1912): XXX FIXME : Got a mozContentEvent: remote-debugger-prompt
I/GeckoDump( 2585): Video statistics start
I/GeckoDump( 2585): Dimensions: 352x288
I/GeckoDump( 2585): Complete duration: 00:09
I/GeckoDump( 2585): Start time: 00:00
I/GeckoDump( 2585): End time: 00:01
I/GeckoDump( 2585): Total frames: 23
I/GeckoDump( 2585): Decoded frames: 23
I/GeckoDump( 2585): Corrupted frames: 0
I/GeckoDump( 2585): Rendered frames: 23
I/GeckoDump( 2585): Dropped frames: 0
I/GeckoDump( 2585): Average rendered FPS: 10.47
I/GeckoDump( 2585): Video statistics end
I/GeckoDump( 1912): XXX FIXME : Got a mozContentEvent: remote-debugger-prompt
I/GeckoDump( 2585): Video statistics start
I/GeckoDump( 2585): Dimensions: 352x288
I/GeckoDump( 2585): Complete duration: 00:09
I/GeckoDump( 2585): Start time: 00:01
I/GeckoDump( 2585): End time: 00:04
I/GeckoDump( 2585): Total frames: 51
I/GeckoDump( 2585): Decoded frames: 51
I/GeckoDump( 2585): Corrupted frames: 0
I/GeckoDump( 2585): Rendered frames: 50
I/GeckoDump( 2585): Dropped frames: 1
I/GeckoDump( 2585): Average rendered FPS: 11.90
I/GeckoDump( 2585): Video statistics end
I/GeckoDump( 1912): XXX FIXME : Got a mozContentEvent: remote-debugger-prompt

Comment 11

[Diego Wilson [:diego]]

(In reply to Sotaro Ikeda [:sotaro] from comment #8)
> On master, it checks "media.mediasource.enabled" and
> "media.mediasource.whitelist".
> 
> https://dxr.mozilla.org/mozilla-central/source/dom/media/mediasource/
> MediaSource.cpp#339
> 
> But on b2g v2.2, it checks "media.mediasource.enabled" and
> "media.mediasource.youtubeonly".

Looks like this works. Thanks!