1145741 - [e10s] ensure tab close button's visibility is based off visuallyselected attribute

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[George Wright (:gw280) (needinfo me!)]

From mconley's review at https://bugzilla.mozilla.org/show_bug.cgi?id=1066531#c59:

"The only glitch I've found is that the tab close button appears in the logically selected case instead of the visually selected case. I'm OK for that to get fixed in a follow-up though, since I know this is a big patch that's been languishing."

Comment 1

[George Wright (:gw280) (needinfo me!)]

Attachment: 0001-Bug-1145741-Style-tab-close-button-off-visuallyselec.patch

Nice simple fix here. Turns out I missed a couple of places where visuallyselected should have been the trigger attribute for tab-close-button instead of selected. This should work fine as we inherit the visuallyselected property from the tab.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8604388 [details] [diff] [review]
0001-Bug-1145741-Style-tab-close-button-off-visuallyselec.patch

Review of attachment 8604388 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, much better! Thanks George!

Comment 3

[George Wright (:gw280) (needinfo me!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26b478800777

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/26b478800777