Closed
Bug 1145741
Opened 10 years ago
Closed 10 years ago
[e10s] ensure tab close button's visibility is based off visuallyselected attribute
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 41
People
(Reporter: gw280, Assigned: gw280)
Details
Attachments
(1 file)
|
1.31 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
From mconley's review at https://bugzilla.mozilla.org/show_bug.cgi?id=1066531#c59:
"The only glitch I've found is that the tab close button appears in the logically selected case instead of the visually selected case. I'm OK for that to get fixed in a follow-up though, since I know this is a big patch that's been languishing."
|
Assignee | |
Updated•10 years ago
|
tracking-e10s:
--- → ?
|
||
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
Nice simple fix here. Turns out I missed a couple of places where visuallyselected should have been the trigger attribute for tab-close-button instead of selected. This should work fine as we inherit the visuallyselected property from the tab.
Attachment #8604388 -
Flags: review?(mconley)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8604388 [details] [diff] [review]
0001-Bug-1145741-Style-tab-close-button-off-visuallyselec.patch
Review of attachment 8604388 [details] [diff] [review]:
-----------------------------------------------------------------
Ah, much better! Thanks George!
Attachment #8604388 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in
before you can comment on or make changes to this bug.
Description
•