Closed
Bug 1145757
Opened 11 years ago
Closed 6 years ago
Remaining "That's bogus!!" comment in nsScriptSecurityManager
Categories
(Core :: Security: CAPS, defect)
Core
Security: CAPS
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: mccr8, Unassigned)
Details
(Keywords: sec-audit)
Bug 1144991 removed an instance of "That's bogus!! Fix this." from nsScriptSecurityManager, but there's another one in the file:
816 // resource: and chrome: are equivalent, securitywise
817 // That's bogus!! Fix this. But watch out for
818 // the view-source stylesheet?
819 bool sourceIsChrome;
820 rv = NS_URIChainHasFlags(sourceURI,
821 nsIProtocolHandler::URI_IS_UI_RESOURCE,
822 &sourceIsChrome);
Somebody should take a look at it to figure out if we have another similar issue with this one.
| Reporter | ||
Comment 1•11 years ago
|
||
This is for the case of URI_IS_LOCAL_FILE. I guess if a random web page can control a random file:// thing we're already in trouble.
Comment 2•11 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #1)
> This is for the case of URI_IS_LOCAL_FILE. I guess if a random web page can
> control a random file:// thing we're already in trouble.
But this is about when the _target_ is a file:// URI (i.e. loading it), right?
I commented a bit about this in bug 1144991 comment 12.
| Reporter | ||
Comment 3•11 years ago
|
||
(In reply to Bobby Holley (:bholley) from comment #2)
> But this is about when the _target_ is a file:// URI (i.e. loading it),
> right?
Oh right, thanks. I'll look over your comment.
Updated•11 years ago
|
Group: core-security → dom-core-security
Comment 4•6 years ago
|
||
I just checked and the file nsScriptSecurityManager does not contain the phrase "That's bogus", not even "bogus". The other info I absorbed from the comments within this bug is a concern around file: URIs. Since we started to treat file: URIs as unique origins over in Bug 1558299, I think this bug can be resolved as INVALID.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Updated•3 years ago
|
Group: dom-core-security
Resolution: INVALID → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•