1145854 - Fix leak in WrapperOwner::className

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

BaseProxyHandler::className is supposed to return a 'const char *' that is owned by... someone. In practice all callers immediately copy the return value. CPOWs leak the return value, which shows up in LSan stats. I'd like to return a string that's valid for as long as the proxy object is alive.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

WrapperAnswer::ToString uses NS_ConvertASCIItoUTF16.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Maybe we should just convert the IPDL type to nsCString.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v2

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8580939 [details] [diff] [review]
patch v2

Review of attachment 8580939 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=891c1fefc668

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7264dc608584

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7264dc608584