1145924 - JSRuntime::updateProfilerSampleBufferGen isn't monotonic increasing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Shu-yu Guo [:shu]]

I think this is causing weird GC crashes, since our friends the SyncProfiles, with their own ProfileBuffers, can reset a runtime's generation back to 0.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Ensure JSRuntime is kept in sync with the profiler.

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 8581040 [details] [diff] [review]
Ensure JSRuntime is kept in sync with the profiler.

Review of attachment 8581040 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/JitcodeMap.h
@@ +600,5 @@
>      }
>      void setGeneration(uint32_t gen) {
>          baseEntry().setGeneration(gen);
>      }
> +    void setAsExpired() {

Nice.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1d410fe6bf99