1146032 - Parser gives wrong location for LHS pattern of list comprehension

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

If I do this:

Reflect.parse("[ for (x of a) x+1 ]")

Then I get a result that contains the following:

                type: "ComprehensionBlock",
                left: {
                    loc: {
                        start: {
                            line: 1,
                            column: 13
                        },
                        end: {
                            line: 1,
                            column: 14
                        },
                        source: null
                    },
                    type: "Identifier",
                    name: "x"
                },
 
The location information for "x" is actually the close paren. This patch fixes that.

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 8581184 [details] [diff] [review]
patch

Review of attachment 8581184 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/js1_8_5/extensions/reflect-parse.js
@@ +1462,5 @@
>  
>  Pattern({ source: "quad.js", start: { line: 1, column: 20 }, end: { line: 1, column: 29 } }).match(fourAC.loc);
>  
> +var generator = Reflect.parse("[ for (x of a) x+1 ]");
> +Pattern({ start: { line: 1, column: 7 }, end: { line: 1, column: 8 } }).match(generator.body[0].expression.blocks[0].left.loc);

Maybe throw in a newline or something, to make even *more* clear that the numbering is correct, by forcing the token onto a line different from where it currently is.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c1c1cc9ef073

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c1c1cc9ef073