1146034 - Lighting and Specular Highlight not rendered with ANGLE D3D11

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Luke]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150320030211

Steps to reproduce:

What steps will reproduce the problem?
1. Firefox on Windows PC go to http://esenthel.com/?id=live_demo
2. In Firefox with about:config webgl.angle.try-d3d11 = FALSE, go to http://esenthel.com/?id=live_demo
3. Compare

What is the expected output? What do you see instead?
Note the Specular Highlights are missing in newer versions of Chrome/Firefox. This does not affect Firefox with dx9 ANGLE or ANGLE disabled.

What version of the product are you using? On what operating system?
Chrome Version 42.0.2291.0 canary (64-bit)
Firefox Nightly 38.0a1 (2015-01-29)
Windows 7 




Expected results:

D3D9 and D3D11 should render the same way.  Chrome also suffered from this exact same issue, but it was fixed in Chrome over a month ago.

https://code.google.com/p/angleproject/issues/detail?id=902

Comment 1

[Jeff Muizelaar [:jrmuizel]]

[Tracking Requested - why for this release]: This is a WebGL content regression caused by bug 1079398

Comment 2

[Jeff Muizelaar [:jrmuizel]]

It would be great if you could figure out which ANGLE update that chrome did that fixed the problem. That will help us find the actual commit that fixed it.

http://www.chromium.org/developers/bisect-builds-py may be of some help.

Comment 3

[Luke]

Thanks, I was not aware of bisect-builds-py. It's not as polished as mozregression, but I was able to track it down to:

You are probably looking for a change made after 316628 (known good), but no lat
er than 316641 (first known bad).

CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/1d4a06266c0abc6be779f8acf5
0cb2f18c5c0d89..2d616c68a8fd923e378b6473302c1406f19aa8cb 

Looks like the fix occurred in this commit-> ANGLE 592ab9dd91e6..d2d21dcadcc

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Thanks. That should help.

Can you post the source of the shader that isn't working properly?

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Jeff - Unless you have a safe fix available today, we're too late in 37 to take a fix. This regression will need to be fixed in 38. Tracking regression.

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

We're now too late for 37. Marking 37 as wontfix.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Looks like this was fixed by ANGLE commit 2857f489f32372310014888342c6f9c97fac5995

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Applying the patch fixes the problem but seems to cause crashes while running the tests:
https://tbpl.mozilla.org/?tree=Try&rev=6b083f596d8e

Comment 9

[Jeff Muizelaar [:jrmuizel]]

I mismerged the patch. The correct one should be fine.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d245389ba33c

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d245389ba33c

Comment 12

[Milan Sreckovic [:milan] (needinfo for best results)]

If this fixes bug 1093037, we definitely want to uplift to 38.

Comment 13

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Milan Sreckovic [:milan] from comment #12)
> If this fixes bug 1093037, we definitely want to uplift to 38.

Although, the dates don't quite line up...

Comment 14

[Jeff Muizelaar [:jrmuizel]]

I don't expect this to fix 1093037

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Jeff, do you want to uplift this to beta(38)? Thanks

Comment 16

[Jeff Muizelaar [:jrmuizel]]

Attachment: Cherry pick fix from ANGLE

Approval Request Comment
[Feature/regressing bug #]: 1079398
[User impact if declined]: Broken WebGL content
[Describe test coverage new/current, TreeHerder]: Not much test coverage for this specific problem, but has been on Nightly for a while without problem. The ANGLE code is tested/shipped by Chrome. Our WebGL test coverage is decent so I don't expect regressions
[Risks and why]: Could break other WebGL content because of shader compiler changes, but this it not too likely

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8589206 [details] [diff] [review]
Cherry pick fix from ANGLE

Aurora is already fixed.
Taking it, it should be in 38 beta 3.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9adbbf9a8784