Closed Bug 1146046 Opened 10 years ago Closed 10 years ago

Update the not-an-article testcase in testReadingListCache to be really not an article

Categories

(Firefox for Android Graveyard :: Testing, defect)

Product:
Firefox for Android Graveyard
Component:
Testing
Version:
38 Branch
Platform:
Other
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox38 fixed, firefox39 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

Details

Attachments

(1 file)

Update testReadingListCache non-reader-able testcase
53.46 KB, patch
rnewman
: review+
Details | Diff | Splinter Review
With some new Readability.js changes, our "not an article" testcase is now being detected as an article. We should update the testcase to be less reader-able.
Attachment #8581204 - Flags: review?(mark.finkle)
Attachment #8581204 - Flags: review?(mark.finkle) → review+
Status: NEW → ASSIGNED
Version: Firefox 35 → Firefox 38
https://hg.mozilla.org/integration/fx-team/rev/75134b207f0d We'll need to uplift this before uplifting the Readability.js changes.
status-firefox38: --- → affected
https://hg.mozilla.org/mozilla-central/rev/75134b207f0d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: