1146096 - sctp: build on linux with musl libc

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Felix Janda]

Compilation of firefox' sctp code currently fails on musl libc (http://musl-libc.org) based systems.

The issues have been fixed upstream (https://code.google.com/p/sctp-refimpl/issues/detail?id=10) with revisions 9187, 9188, 9189 and 9190. Could the firefox version be updated to upstream trunk?

After that compilation will still fail because configure will now also have to check for <sys/queue.h> and declare HAVE_SYS_QUEUE_H accordingly. I can try to come up with a patch if necessary.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: update usrsctp to rev 9196 from upstream rs=jesup

Pick up build fixes for musl-libc from upstream

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: rollup of sctp modifications for Android rs=jesup

Comment 3

[Felix Janda]

Attachment: sctp-configure.patch

Thanks for the update!

I've however noticed that the update will likely break the windows build without checking for <sys/queue.h> in configure. (The upstream configure script now checks for the existence of <sys/queue.h> instead of automatically using a fallback for windows.)

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad93d67516e6

Let me look at configure.in

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: configure.in updates for SCTP and musl.libc (sys/queue.h)

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Attachment: update usrsctp to rev 9209 from upstream rs=jesup

Pick up build fixes for musl-libc from upstream and a null-deref fix

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

How does this look?

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8582716 [details] [diff] [review]
configure.in updates for SCTP and musl.libc (sys/queue.h)

Trivial add of a CHECK_HEADERS for sys/queue.h

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8581895 [details] [diff] [review]
sctp-configure.patch

Review of attachment 8581895 [details] [diff] [review]:
-----------------------------------------------------------------

Let's use this instead (but without the []'s I think)

Comment 10

[Felix Janda]

Attachment: sctp-configure.patch

Comment 11

[Felix Janda]

Thanks! It compile fine for me with the patches.

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8583337 [details] [diff] [review]
sctp-configure.patch

Trivial review (1-liner MOZ_CHECK_HEADERS for sys/queue.h)

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ee51b896998
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d2301ec8a53
https://hg.mozilla.org/integration/mozilla-inbound/rev/f83da99e5610

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ee51b896998
https://hg.mozilla.org/mozilla-central/rev/1d2301ec8a53
https://hg.mozilla.org/mozilla-central/rev/f83da99e5610