Closed Bug 1146096 Opened 5 years ago Closed 5 years ago

sctp: build on linux with musl libc

Categories

(Core :: WebRTC: Networking, defect)

Other
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: felix.janda, Assigned: jesup)

Details

Attachments

(3 files, 3 obsolete files)

Compilation of firefox' sctp code currently fails on musl libc (http://musl-libc.org) based systems.

The issues have been fixed upstream (https://code.google.com/p/sctp-refimpl/issues/detail?id=10) with revisions 9187, 9188, 9189 and 9190. Could the firefox version be updated to upstream trunk?

After that compilation will still fail because configure will now also have to check for <sys/queue.h> and declare HAVE_SYS_QUEUE_H accordingly. I can try to come up with a patch if necessary.
Pick up build fixes for musl-libc from upstream
Assignee: nobody → rjesup
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached patch sctp-configure.patch (obsolete) — Splinter Review
Thanks for the update!

I've however noticed that the update will likely break the windows build without checking for <sys/queue.h> in configure. (The upstream configure script now checks for the existence of <sys/queue.h> instead of automatically using a fallback for windows.)
Pick up build fixes for musl-libc from upstream and a null-deref fix
How does this look?
Flags: needinfo?(felix.janda)
Comment on attachment 8582716 [details] [diff] [review]
configure.in updates for SCTP and musl.libc (sys/queue.h)

Trivial add of a CHECK_HEADERS for sys/queue.h
Attachment #8582716 - Flags: review?(gps)
Attachment #8581807 - Attachment is obsolete: true
Comment on attachment 8581895 [details] [diff] [review]
sctp-configure.patch

Review of attachment 8581895 [details] [diff] [review]:
-----------------------------------------------------------------

Let's use this instead (but without the []'s I think)
Attachment #8581895 - Flags: review?(gps)
Attachment #8582716 - Attachment is obsolete: true
Attachment #8582716 - Flags: review?(gps)
Attachment #8581808 - Flags: review+
Attachment #8582717 - Flags: review+
Attachment #8581895 - Attachment is obsolete: true
Attachment #8581895 - Flags: review?(gps)
Flags: needinfo?(felix.janda)
Thanks! It compile fine for me with the patches.
Comment on attachment 8583337 [details] [diff] [review]
sctp-configure.patch

Trivial review (1-liner MOZ_CHECK_HEADERS for sys/queue.h)
Attachment #8583337 - Flags: review?(gps)
Attachment #8583337 - Flags: review?(gps) → review+
You need to log in before you can comment on or make changes to this bug.