1146122 - Handle response stanza to _sendPresence

Status: RESOLVED FIXED

(Chat Core :: XMPP, defect)

Description

[aleth [:aleth]]

With the improved warnings added in bug 954960, it is apparent we don't handle the response presence stanza to the presence stanzas we send in _sendPresence.

Comment 1

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: rev 1 - Handle response to _sendPresence

Comment 2

[aleth [:aleth]]

Comment on attachment 8589897 [details] [diff] [review]
rev 1 - Handle response to _sendPresence

Review of attachment 8589897 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/xmpp/xmpp.jsm
@@ +1542,5 @@
>        let priority = Math.max(-128, Math.min(127, this.getInt("priority")));
>        if (priority)
>          children.push(Stanza.node("priority", null, null, priority.toString()));
>      }
> +    this.sendStanza(Stanza.presence({"xml:lang": "en"}, children),

Please add a comment explaining the handler (something like "As we are implicitly subscribed to our own presence (rfc...), we will receive the presence stanza mirrored back to us. We don't need to do anything with this response."

Comment 3

[aleth [:aleth]]

r+ with the added comment.

Comment 4

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: rev 2 - Handle response to _sendPresence

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/27db63dc0e76